Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to migrate from v0.10 to v0.11
v0.11 has a few subtle breaking changes to
eof
andseekend
.Memory(data::ByteData)
The
Memory(data::ByteData)
constructor was removed.Use
Memory(pointer(data), sizeof(data))
instead.seekend(stream::TranscodingStream)
Generic
seekend
forTranscodingStream
was removed.If the objective is to discard all remaining data in the stream, use
skip(stream, typemax(Int64))
instead wheretypemax(Int64)
is meant to be a large number to exhaust the stream.Ideally, specific implementations of
TranscodingStream
will implementseekend
only if efficient means exist to avoid fully processing the stream.NoopStream
still supportsseekend
.The previous behavior of the generic
seekend
was something like(seekstart(stream); seekend(stream.stream); stream)
but this led toinconsistencies with the position of the stream.
eof(stream::TranscodingStream)
eof
now throws an error if called on a stream that is closed or in writing mode.Use
!isreadable(stream) || eof(stream)
if you need to more closely match previous behavior.