Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating README / New naming convention? #98

Closed
mipals opened this issue Feb 15, 2024 · 4 comments
Closed

Updating README / New naming convention? #98

mipals opened this issue Feb 15, 2024 · 4 comments

Comments

@mipals
Copy link
Member

mipals commented Feb 15, 2024

Hi again,

I do not really know the customs here in GitHub. Should this be an issue or a discussion?

As pardiso-project / Pardiso 6 seem to no longer be a thing, many of the naming conventions in both the README and code seem outdated. Before I start changing stuff, it might be a good idea that we agree on a new name.

On their website it does look like the name that they go for is Panua-Pardiso, so maybe we should stick to that?

panua-pardiso

Cheers,
Mikkel

@j-fu
Copy link
Collaborator

j-fu commented Feb 15, 2024

Hi, I already prepared some modifications regarding panua in the README etc of #75. Still waiting if they will come up with a fix.
Yes, I guess we should refer to it as Panua-Pardiso.

@KristofferC
Copy link
Member

Makes sense to me.

@mipals
Copy link
Member Author

mipals commented Feb 15, 2024

Perfect, lets go with that.

I will have a look at those changes Jürgen.

In addition, I was not just thinking of changing the README, but also the references in the code, i.e. the build still uses libpardiso600, the file called project_pardiso.jl, etc. But maybe e.g. the build breaks the code of people using 6.0?

@j-fu
Copy link
Collaborator

j-fu commented Mar 1, 2024

Guess we can close this with #75.

@j-fu j-fu closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants