Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React Mapbox GL and/or Mapbox GL #407

Open
toolness opened this issue Aug 26, 2020 · 1 comment
Open

Upgrade React Mapbox GL and/or Mapbox GL #407

toolness opened this issue Aug 26, 2020 · 1 comment

Comments

@toolness
Copy link
Contributor

toolness commented Aug 26, 2020

A bunch of the errors we're getting through Rollbar appear to be related to Mapbox GL, and I've noticed when quickly using my browser's back/forward buttons to navigate between WoW pages that some errors get logged related to this component too; for instance:

  • In PropertiesMap.tsx it seems like our onStyleLoad is being called even once the component has been unmounted, which logs an error. It seems like not calling that callback if a React Mapbox component has been unmounted should be the responsibility of React Mapbox GL, not our code, but maybe I'm wrong.

  • A Uncaught TypeError: Cannot read property 'send' of undefined is being logged from mapbox-gl.js and it's triggered by an XMLHttpRequest's onload event handler somewhere in that codebase.

Anyways, it looks like a new major version of React Mapbox GL exists (the one we're using, v3.8.0, is from February 2018) so maybe upgrading it will make some of these errors go away. And even if it doesn't, it will at least rule out the possibility that the errors are being caused by third-party bugs that have since been fixed.

@toolness
Copy link
Contributor Author

We updated react-mapbox-gl in #420, so hopefully that will fix this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant