Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not load_command_class #5

Open
bartekbrak opened this issue Jan 8, 2025 · 0 comments
Open

do not load_command_class #5

bartekbrak opened this issue Jan 8, 2025 · 0 comments

Comments

@bartekbrak
Copy link

utils.py:sync_commands instantiates all Command objects via load_command_class. I say this is harmful, a user (my case) might do expensive operations in given commands __init__, the loaded class is not used except for its help which can be obtained without instantiation.

What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartekbrak