{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":464563019,"defaultBranch":"main","name":"ethermint","ownerLogin":"Kava-Labs","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2022-02-28T16:39:48.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/36107286?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1727484335.0","currentOid":""},"activityList":{"items":[{"before":"8a9282541a4d99a03da0527d10a4ac8733c00309","after":"b276443f7c2d208f1fe3052fb4d0bcec69765c75","ref":"refs/heads/yevhenii/evm-indexer-v26","pushedAt":"2024-09-28T01:55:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"fix: fix bug in evm-indexer","shortMessageHtmlLink":"fix: fix bug in evm-indexer"}},{"before":"dccfd5a08097ed57a158fde8d41df4184d157b17","after":"8a9282541a4d99a03da0527d10a4ac8733c00309","ref":"refs/heads/yevhenii/evm-indexer-v26","pushedAt":"2024-09-28T01:36:12.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"fix: fix bug in evm-indexer","shortMessageHtmlLink":"fix: fix bug in evm-indexer"}},{"before":"5b3ec56fa7f81f01fe9301f68fccaae0fa835d3a","after":"dccfd5a08097ed57a158fde8d41df4184d157b17","ref":"refs/heads/yevhenii/evm-indexer-v26","pushedAt":"2024-09-28T01:34:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"fix: fix bug in evm-indexer","shortMessageHtmlLink":"fix: fix bug in evm-indexer"}},{"before":"5b3ec56fa7f81f01fe9301f68fccaae0fa835d3a","after":"8c96f0354a6d39202b28390bec543b87d1e096f5","ref":"refs/heads/kava/release/v0.26.x","pushedAt":"2024-09-28T00:46:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"Upgrade opendb (#71)","shortMessageHtmlLink":"Upgrade opendb (#71)"}},{"before":null,"after":"5b3ec56fa7f81f01fe9301f68fccaae0fa835d3a","ref":"refs/heads/yevhenii/evm-indexer-v26","pushedAt":"2024-09-28T00:45:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"fix: fix bug in evm-indexer","shortMessageHtmlLink":"fix: fix bug in evm-indexer"}},{"before":"8c96f0354a6d39202b28390bec543b87d1e096f5","after":"5b3ec56fa7f81f01fe9301f68fccaae0fa835d3a","ref":"refs/heads/kava/release/v0.26.x","pushedAt":"2024-09-28T00:43:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"fix: fix bug in evm-indexer","shortMessageHtmlLink":"fix: fix bug in evm-indexer"}},{"before":"78df2e89c647349d0baacfa11b2941fb2eec516f","after":"fb6a6a2458d1f59a7b828bd559cb8e4baa2eeac3","ref":"refs/heads/yevhenii/evm-indexer-bugfix","pushedAt":"2024-09-27T19:09:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"fix: fix bug in evm-indexer","shortMessageHtmlLink":"fix: fix bug in evm-indexer"}},{"before":null,"after":"78df2e89c647349d0baacfa11b2941fb2eec516f","ref":"refs/heads/yevhenii/evm-indexer-bugfix","pushedAt":"2024-09-27T19:07:35.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"fix: fix bug in evm-indexer","shortMessageHtmlLink":"fix: fix bug in evm-indexer"}},{"before":"8e41a3f8cd2a12717d47ae566baa24d759a4ebd0","after":"1e0556e13958e6e6f9666eef40154a98502bafcf","ref":"refs/heads/yevhenii/evm-indexer","pushedAt":"2024-09-27T14:29:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"Minor fix in logs","shortMessageHtmlLink":"Minor fix in logs"}},{"before":"039dfe16bf52de9166a1aae824dcc7f91055a867","after":"8e41a3f8cd2a12717d47ae566baa24d759a4ebd0","ref":"refs/heads/yevhenii/evm-indexer","pushedAt":"2024-09-27T12:53:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"Added debug logs","shortMessageHtmlLink":"Added debug logs"}},{"before":"8b6ab9de2a9c0ebc7c971afff65ea74f8a7cd10f","after":"039dfe16bf52de9166a1aae824dcc7f91055a867","ref":"refs/heads/yevhenii/evm-indexer","pushedAt":"2024-09-26T14:40:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"Enable error logs back","shortMessageHtmlLink":"Enable error logs back"}},{"before":null,"after":"8b6ab9de2a9c0ebc7c971afff65ea74f8a7cd10f","ref":"refs/heads/yevhenii/evm-indexer","pushedAt":"2024-09-26T13:40:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"evgeniy-scherbina","name":"Evgeniy Scherbina","path":"/evgeniy-scherbina","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/37836031?s=80&v=4"},"commit":{"message":"Added debug logs","shortMessageHtmlLink":"Added debug logs"}},{"before":"a9b525ab00df083993441c189b6a7b892284dcf2","after":null,"ref":"refs/heads/dl-eip712-domainsep-fix","pushedAt":"2024-09-19T18:42:39.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"drklee3","name":null,"path":"/drklee3","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22536567?s=80&v=4"}},{"before":"586960857184b7f2b9371ad937cd36e9b67c37c2","after":"65384e03c3e77993419db3c652b16f8849805f75","ref":"refs/heads/main","pushedAt":"2024-09-19T18:42:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"drklee3","name":null,"path":"/drklee3","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22536567?s=80&v=4"},"commit":{"message":"fix!: Remove unused fields verifyingContract & salt from EIP712 domain separator (#75)\n\nverifyingContract field is validated by MetaMask to be an address, but was expected to be a string. This field is unused so it is removed.","shortMessageHtmlLink":"fix!: Remove unused fields verifyingContract & salt from EIP712 domai…"}},{"before":"0937314ba85f3155a2601b5080389419dc9eceb2","after":"a9b525ab00df083993441c189b6a7b892284dcf2","ref":"refs/heads/dl-eip712-domainsep-fix","pushedAt":"2024-09-10T23:34:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"drklee3","name":null,"path":"/drklee3","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22536567?s=80&v=4"},"commit":{"message":"ci: Re-add get-diff-action\n\nsomehow deleted this on accident","shortMessageHtmlLink":"ci: Re-add get-diff-action"}},{"before":"1b4cd7b323781e700c78244663f410953607875b","after":"0937314ba85f3155a2601b5080389419dc9eceb2","ref":"refs/heads/dl-eip712-domainsep-fix","pushedAt":"2024-09-10T23:12:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"drklee3","name":null,"path":"/drklee3","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22536567?s=80&v=4"},"commit":{"message":"ci: Remove ci accidentally included permissions","shortMessageHtmlLink":"ci: Remove ci accidentally included permissions"}},{"before":"4546e35f49f72887714c174718873c12a3ae0884","after":"1b4cd7b323781e700c78244663f410953607875b","ref":"refs/heads/dl-eip712-domainsep-fix","pushedAt":"2024-09-10T23:06:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"drklee3","name":null,"path":"/drklee3","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22536567?s=80&v=4"},"commit":{"message":"ci: Pin golangci-lint to v1.59","shortMessageHtmlLink":"ci: Pin golangci-lint to v1.59"}},{"before":"314ef3c12c9390756a89aefe70e11e826e9f3529","after":"4546e35f49f72887714c174718873c12a3ae0884","ref":"refs/heads/dl-eip712-domainsep-fix","pushedAt":"2024-09-10T19:46:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"drklee3","name":null,"path":"/drklee3","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22536567?s=80&v=4"},"commit":{"message":"test: Remove verifyingContract & salt from expected msg types","shortMessageHtmlLink":"test: Remove verifyingContract & salt from expected msg types"}},{"before":"f51228ddc7a691718da5c5ce98538eb83c1084af","after":"314ef3c12c9390756a89aefe70e11e826e9f3529","ref":"refs/heads/dl-eip712-domainsep-fix","pushedAt":"2024-09-10T19:41:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"drklee3","name":null,"path":"/drklee3","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22536567?s=80&v=4"},"commit":{"message":"Remove unused EIP712Domain types","shortMessageHtmlLink":"Remove unused EIP712Domain types"}},{"before":"41eb33aaca8cc9bd5fdda35b5dcfb1e4e285d739","after":"f51228ddc7a691718da5c5ce98538eb83c1084af","ref":"refs/heads/dl-eip712-domainsep-fix","pushedAt":"2024-09-10T19:36:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"drklee3","name":null,"path":"/drklee3","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22536567?s=80&v=4"},"commit":{"message":"fix: Remove VerifyingContract field from EIP712 domain separator","shortMessageHtmlLink":"fix: Remove VerifyingContract field from EIP712 domain separator"}},{"before":null,"after":"8c96f0354a6d39202b28390bec543b87d1e096f5","ref":"refs/heads/kava/release/v0.27.x","pushedAt":"2024-09-10T19:35:49.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"drklee3","name":null,"path":"/drklee3","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22536567?s=80&v=4"},"commit":{"message":"Upgrade opendb (#71)","shortMessageHtmlLink":"Upgrade opendb (#71)"}},{"before":null,"after":"41eb33aaca8cc9bd5fdda35b5dcfb1e4e285d739","ref":"refs/heads/dl-eip712-domainsep-fix","pushedAt":"2024-09-10T19:34:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"drklee3","name":null,"path":"/drklee3","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/22536567?s=80&v=4"},"commit":{"message":"fix: Remove VerifyingContract field from EIP712 domain separator","shortMessageHtmlLink":"fix: Remove VerifyingContract field from EIP712 domain separator"}},{"before":"b2308ed54c25166aea709040b0b64109dc273aab","after":null,"ref":"refs/heads/nd-strict-genesis-validations","pushedAt":"2024-08-02T22:40:15.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nddeluca","name":"Nick DeLuca","path":"/nddeluca","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/903469?s=80&v=4"}},{"before":"0d4e75cd186f014cf687ab4391a2f885eabc26e3","after":"586960857184b7f2b9371ad937cd36e9b67c37c2","ref":"refs/heads/main","pushedAt":"2024-08-02T22:40:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"nddeluca","name":"Nick DeLuca","path":"/nddeluca","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/903469?s=80&v=4"},"commit":{"message":"feat!: Enforce stricter validations for genesis accounts and enabled precompiles (#74)\n\n* feat!: Genesis Accounts can not contain empty code\r\n\r\nGenesis accounts currently serve no purpose for non-contract accounts.\r\nCurrently, they can exist but code and storage will be empty and\r\ntherefore has no effect besids ensuring the matching account is subject\r\nto similar validations as a contract.\r\n\r\nThis change restrics valid genesis accounts to those with Code only.\r\nStorage can still be empty for contracts, as there is no requirement for\r\nvalues to be set in state for all contracts.\r\n\r\n* refactor: Capitalize test case names\r\n\r\nUsing capital letters for test case names improved readability when\r\nreading and parsing.\r\n\r\n* fix!: Add back code hash check for empty code\r\n\r\nOn some chains running ethermint, a self destruct bug that caused the\r\ncode for other contract accounts to be deleted would result in exported\r\ngenesis accounts with empty code. A patch was then added to genesis\r\nthat allowed the hash check to be skipped in order for these genesis\r\nfiles to be re-imported successfully.\r\n\r\nThis does not affect us contracts on Kava, so this check is being\r\nremoved.\r\n\r\n* feat!: Add strict contract account checks\r\n\r\nSince Genesis Accounts may only be contracts, we add the assertion that\r\nthey must have a positive sequence (eip-155) and that they do not have a\r\npublic key set. A contract can not be associated with a public key and\r\nmust have a default nonce set.\r\n\r\nIn addition, since enabled precompiles are contract accounts, we enforce\r\nthat these have matching genesis accounts to share these validations and\r\nin addition, enforce a fixed code.","shortMessageHtmlLink":"feat!: Enforce stricter validations for genesis accounts and enabled …"}},{"before":"cd02af6027d32e263de6cd2595f6d9809e883105","after":"b2308ed54c25166aea709040b0b64109dc273aab","ref":"refs/heads/nd-strict-genesis-validations","pushedAt":"2024-08-02T21:25:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nddeluca","name":"Nick DeLuca","path":"/nddeluca","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/903469?s=80&v=4"},"commit":{"message":"feat!: Add strict contract account checks\n\nSince Genesis Accounts may only be contracts, we add the assertion that\nthey must have a positive sequence (eip-155) and that they do not have a\npublic key set. A contract can not be associated with a public key and\nmust have a default nonce set.\n\nIn addition, since enabled precompiles are contract accounts, we enforce\nthat these have matching genesis accounts to share these validations and\nin addition, enforce a fixed code.","shortMessageHtmlLink":"feat!: Add strict contract account checks"}},{"before":"e52fdf30125ac2c8753827c81eca86f32ecc9391","after":null,"ref":"refs/heads/nd-improve-evm-genesis-testing","pushedAt":"2024-08-02T21:22:12.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"nddeluca","name":"Nick DeLuca","path":"/nddeluca","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/903469?s=80&v=4"}},{"before":"9ce0e8db206a0049969fa5d75af27247c3d0a6d0","after":"0d4e75cd186f014cf687ab4391a2f885eabc26e3","ref":"refs/heads/main","pushedAt":"2024-08-02T21:22:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"nddeluca","name":"Nick DeLuca","path":"/nddeluca","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/903469?s=80&v=4"},"commit":{"message":"test: Improve x/evm genesis tests (#73)\n\n* test: Improve x/evm genesis tests\r\n\r\nPreviously, the InitGenesis function did not have complete unit\r\ncoverage, did not check for panic values, and shared a test suite with\r\nthe handler. This created dependencies on setup for unrelated tests and\r\nmade it difficult to add, change, or refactor genesis behavior with\r\nconfidence.\r\n\r\nThese changes use a fixture based approach to testing InitGenesis which\r\nimproves the ability to define more complex test cases and run each sub\r\ntest in isolation. Once global state is removed from app setup, this\r\nenables an easier transition to parallel tests.\r\n\r\nThis comes from the ability to setup the application, define a function\r\nfor each test that is provided a context and app, then generates a\r\nfixture with required dependencies and expectations. This allows\r\ncontext to be shared across state setup, expectations, and panic values.\r\n\r\nIn addition, all InitGenesis behavior was checked in TDD fashion and\r\ntests were added where coverage was lacking before.\r\n\r\n* refactor: ExpectFunc default should be nil\r\n\r\nWhen defining a test fixture with no expectations, the test fixture\r\nshould use a nil function for expectFunc, instead of an empty function\r\nwhich serves no purpose.\r\n\r\nThis also ensures we check for nil before calling the set function in\r\norder to prevent panics.\r\n\r\n* refactor: Test Cases names should be capitalized\r\n\r\nWhen reading, parsing test names from file, or reading verbose test\r\noutput, a capital test name is much clearer to read and comprehend than\r\nan uncapitalized one. We mimic git commit message subjects in this\r\nsense.\r\n\r\n* fix: Fix incorrect capitalization of panic value\r\n\r\nI screwed this up when renaming test names, correct expected value.","shortMessageHtmlLink":"test: Improve x/evm genesis tests (#73)"}},{"before":null,"after":"cd02af6027d32e263de6cd2595f6d9809e883105","ref":"refs/heads/nd-strict-genesis-validations","pushedAt":"2024-08-01T15:31:29.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"nddeluca","name":"Nick DeLuca","path":"/nddeluca","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/903469?s=80&v=4"},"commit":{"message":"feat!: Add strict contract account checks\n\nSince Genesis Accounts may only be contracts, we add the assertion that\nthey must have a positive sequence (eip-155) and that they do not have a\npublic key set. A contract can not be associated with a public key and\nmust have a default nonce set.\n\nIn addition, since enabled precompiles are contract accounts, we enforce\nthat these have matching genesis accounts to share these validations and\nin addition, enforce a fixed code.","shortMessageHtmlLink":"feat!: Add strict contract account checks"}},{"before":"c57e68caa1a25822cc46287e770fda29999684bf","after":"e52fdf30125ac2c8753827c81eca86f32ecc9391","ref":"refs/heads/nd-improve-evm-genesis-testing","pushedAt":"2024-07-30T18:56:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nddeluca","name":"Nick DeLuca","path":"/nddeluca","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/903469?s=80&v=4"},"commit":{"message":"fix: Fix incorrect capitalization of panic value\n\nI screwed this up when renaming test names, correct expected value.","shortMessageHtmlLink":"fix: Fix incorrect capitalization of panic value"}},{"before":"f2f0d6cb2880123d221ce4e9ba365df2628b9939","after":"c57e68caa1a25822cc46287e770fda29999684bf","ref":"refs/heads/nd-improve-evm-genesis-testing","pushedAt":"2024-07-30T18:11:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nddeluca","name":"Nick DeLuca","path":"/nddeluca","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/903469?s=80&v=4"},"commit":{"message":"refactor: Test Cases names should be capitalized\n\nWhen reading, parsing test names from file, or reading verbose test\noutput, a capital test name is much clearer to read and comprehend than\nan uncapitalized one. We mimic git commit message subjects in this\nsense.","shortMessageHtmlLink":"refactor: Test Cases names should be capitalized"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yOFQwMTo1NTo1NS4wMDAwMDBazwAAAATDJN-i","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNy0zMFQxODoxMTowOC4wMDAwMDBazwAAAASNSeYM"}},"title":"Activity · Kava-Labs/ethermint"}