Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Fix issue with matching patterns #57

Open
6 of 10 tasks
CalvinWilkinson opened this issue Sep 2, 2022 · 0 comments
Open
6 of 10 tasks

🚧Fix issue with matching patterns #57

CalvinWilkinson opened this issue Sep 2, 2022 · 0 comments
Assignees
Labels
🐛bug Something isn't working high-priority High Priority

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Sep 2, 2022

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Currently, the translation between the custom action glob matching syntax and regex syntax has an issue.

feature/setup-build-project

  • Value: feature/setup-build-project
  • Pattern: feature/setup-*-project

This was discovered when using the same code while playing around with Nuke build system framework.

Possible Solution:

  1. The problems are that the globbing pattern needs to always start with a '^' symbol and end with a '$' symbol.
  2. This could possibly just be fixed by improving the regex used. Attempt this solution first.

Also, the RegexOptions.IgnoreCase needs to NOT be used at all. Currently, if the value above had a 'Tfor the wordproject` ad the end, it would still pass. Remove case sensitivity.

Remove the MatchType. enum and its use case as well

Acceptance Criteria

  • The symbol '^' added to the start of the globbingPattern every time in the Match() method
  • The symbol '$' added to the end of the globbingPattern every time in the Match() method
  • Remove the RegexOptions.IgnoreCase argument for all RegEx.Match() method calls

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if applicable).
  • Issue linked to the correct milestone (if applicable).
  • Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
Workflow Changes workflow
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added the 🐛bug Something isn't working label Sep 2, 2022
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.4 milestone Sep 2, 2022
@CalvinWilkinson CalvinWilkinson self-assigned this Sep 2, 2022
@CalvinWilkinson CalvinWilkinson added the high-priority High Priority label Feb 23, 2023
@CalvinWilkinson CalvinWilkinson modified the milestones: v1.0.0-preview.4, v1.0.0-preview.5 Mar 17, 2023
@CalvinWilkinson CalvinWilkinson removed this from the v1.0.0-preview.5 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working high-priority High Priority
Projects
Status: ⚪Not Set
Development

No branches or pull requests

1 participant