Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate curl 7.59 fix for chunked encoding #301

Open
djones6 opened this issue Jun 19, 2019 · 2 comments
Open

Validate curl 7.59 fix for chunked encoding #301

djones6 opened this issue Jun 19, 2019 · 2 comments
Milestone

Comments

@djones6
Copy link
Contributor

djones6 commented Jun 19, 2019

Kitura/Kitura#1465 was raised to track a bug in curl relating to receiving a response with a chunked encoding, which broke in curl 7.57 and was fixed in curl 7.59, but which is shipped in Ubuntu 18.04 (ships curl 7.58).

We need to validate that the 7.59 fix does actually resolve the problem we have with ClientRequest and the duplicate callbacks.

@djones6 djones6 added this to the 2019.12 milestone Jun 19, 2019
@djones6
Copy link
Contributor Author

djones6 commented Jun 19, 2019

Another thing to check: what happens if we build the server in KITURA_NIO mode? Kitura-NIO doesn't use curl, so this may be a workaround of sorts.

@djones6 djones6 assigned RudraniW and unassigned wbittles Sep 25, 2019
@djones6
Copy link
Contributor Author

djones6 commented Sep 25, 2019

@RudraniW I believe that @wbittles did complete this and we established that the fix in curl 7.59 resolves the bug. But you could recreate yourself locally which may help in testing the toleration changes for Kitura-net.

@djones6 djones6 modified the milestones: 2019.12, 2019.20 Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants