Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI warning on failed serialization #15

Open
banesullivan opened this issue Jan 26, 2023 · 1 comment
Open

UI warning on failed serialization #15

banesullivan opened this issue Jan 26, 2023 · 1 comment

Comments

@banesullivan
Copy link
Contributor

Could the local vtk view have some sort of dismissable error popup, perhaps in the bottom corner, that lists the types of data that were unable to be serialized?

In PyVista, we suppress the warnings from VTK to avoid lengthy output in Jupyter:

pyvista/pyvista@c67a5ff

I wonder if in VtkLocalView, we could override that VTK logger and capture this error message:

https://github.com/Kitware/VTK/blob/af0878b870528596009fc9a627a8aa9b90917316/Web/Python/vtkmodules/web/render_window_serializer.py#L184

for the a better UI message directly with trame

@jourdain
Copy link
Collaborator

We should definitely help in that regard, but I will not force a UI onto the user within LocalView. Instead, provide some infrastructure so you can bring your own UI and handle the error your own way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants