Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Static vtkMapper Coincident Topology functions probably don't trigger shader update #3141

Open
PaulHax opened this issue Oct 7, 2024 · 2 comments
Labels
type: bug 🐞 Errors in functionality

Comments

@PaulHax
Copy link
Collaborator

PaulHax commented Oct 7, 2024

Bug description

Just a theory, have not tested but:

Global static calls to functions like vtkMapper.setResolveCoincidentTopologyPolygonOffsetParameters should trigger a shader rebuild.

Steps to reproduce

  1. Trigger intial render of PolyDataMapper.
  2. Set call a static coincident topology function
  3. Do a second render
  4. Verify static API call had an effect.

Detailed Behavior

No response

Expected Behavior

Trigger shader rebuild:
https://github.com/Kitware/vtk-js/blob/master/Sources/Rendering/OpenGL/ImageMapper/index.js#L469

Fix approach discussed here: #3131 (comment)

Environment

  • vtk.js version: 32.3.1
  • Browsers:
  • OS:
@daker
Copy link
Collaborator

daker commented Dec 15, 2024

@PaulHax to close if it was fixed ?

@PaulHax
Copy link
Collaborator Author

PaulHax commented Dec 16, 2024

not fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐞 Errors in functionality
Projects
None yet
Development

No branches or pull requests

2 participants