Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll_transition on room change #71

Open
jalcazo opened this issue Nov 5, 2024 · 4 comments
Open

scroll_transition on room change #71

jalcazo opened this issue Nov 5, 2024 · 4 comments

Comments

@jalcazo
Copy link

jalcazo commented Nov 5, 2024

I suggest that ON TOP of having an “Instant” transition when switching room we have as well the scroll transition that can be seen in Alwa's Legacy or Castlevania's games, and I think Megamans as well in which:

Game freezes (player and characters), for example if player was jumping he/she freezes midair, while we see a transition left to right (or right to left, or bottom to top or top to bottom) fast from one room to another.

I attach Alwa's Legacy footage for reference, is a room very (almost everything) room based: https://www.youtube.com/watch?v=jvKc0ZHA0J0

Alwa's Legacy also uses fade to black and black to normal transitions, so I suggest adding that as well.

I propose that we can adjust scroll speed in a parameter in Godot in inspector (as well as in code).

And somehow we select instant transition or scroll_transition or other future transitions like melt (doom) etc.

Thanks a lot for your FANTASTIC work.

@KoBeWi
Copy link
Owner

KoBeWi commented Nov 6, 2024

This can be already achieved by adjusting the room changing code. It's to be implemented on the project's side, not the addon's. I can make an example later.

@KoBeWi
Copy link
Owner

KoBeWi commented Nov 7, 2024

I created this:

godot_36JXfdy2gL.mp4

ScrollingRoomTransitions.gd.txt

Put it in res://addons/MetroidvaniaSystem/Template/Scripts/Modules/ (without .txt) and change this line

https://github.com/KoBeWi/Metroidvania-System/blob/4dc6d461057a1aeb07122c144e1a049d784ab6c2/SampleProject/Scripts/Game.gd#L64C2-L64C9

to use ScrollingRoomTransitions.

It's not perfect though. Turns out it's not that easy to implement due to various camera quirks. I might improve it later.

@jalcazo
Copy link
Author

jalcazo commented Nov 9, 2024

Thanks a lot, I'll try it.

@DavidMag
Copy link

Could we get the option to modify the path to the modules/scripts just like with the rooms folder so that one does not need to add scripts into the addon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants