fix(core): reduce uninitialized variable message when nginx return 400 #13201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
bungle
previously requested changes
Jun 16, 2024
windmgc
approved these changes
Jun 17, 2024
|
@oowl, did we consider defining those variables? E.g. move them to upper scope or something? Or skipping accessing them when we know they are not there (currently it feels like only reports.lua has this issue, so turning totally off feel like hitting a fly with a hammer)? Uninitialized warnings seems to be nice thing to catch some small issues? So turning it totally off feels like we will also miss something. |
oowl
force-pushed
the
fix/ngx-var-not-init-in-400
branch
2 times, most recently
from
7c5a012
to
5a8629e
Compare
oowl
force-pushed
the
fix/ngx-var-not-init-in-400
branch
from
5a8629e
to
50d6c66
Compare
outsinre
approved these changes
Jul 15, 2024
outsinre
reviewed
Jul 15, 2024
changelog/unreleased/kong/fix-reports-uninitialized-variable-in-400.yml
Outdated
Show resolved
Hide resolved
fffonion
approved these changes
Jul 15, 2024
…n-400.yml Co-authored-by: Zachary Hu <6426329+outsinre@users.noreply.github.com>
oowl
force-pushed
the
fix/ngx-var-not-init-in-400
branch
from
5fb40f4
to
9ffe605
Compare
github-actions
bot
added
the
incomplete-cherry-pick
oowl
added a commit
that referenced
this pull request
Jul 15, 2024
#13201) When Kong receives abnormal traffic, it will trigger 400 responses without initializing any Nginx variable, So it will trigger report.lua error, which is unnecessary. eg: send HTTP traffic to HTTPS port, Nginx will finalize the current request by 400 response in the TLS handshake, So it will never call any openresty HTTP processing phase, it also does not initialize any Nginx variable. Fix #13197 https://konghq.atlassian.net/browse/FTI-6025
kikito
removed
the
incomplete-cherry-pick
oowl
added a commit
that referenced
this pull request
Aug 15, 2024
#13201) When Kong receives abnormal traffic, it will trigger 400 responses without initializing any Nginx variable, So it will trigger report.lua error, which is unnecessary. eg: send HTTP traffic to HTTPS port, Nginx will finalize the current request by 400 response in the TLS handshake, So it will never call any openresty HTTP processing phase, it also does not initialize any Nginx variable. Fix #13197 https://konghq.atlassian.net/browse/FTI-6025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Kong receives abnormal traffic, it will trigger 400 responses without initializing any Nginx variable, So it will trigger
report.luaerror, which is unnecessary.eg: send HTTP traffic to HTTPS port, Nginx will finalize the current request by 400 response in the TLS handshake, So it will never call any openresty HTTP processing phase, it also does not initialize any Nginx variable.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #13197
https://konghq.atlassian.net/browse/FTI-6025