Add onInitialStateReceived callback, update Kotlin to 2.0 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g0rd1
requested changes
Oct 28, 2024
| import ru.kontur.mobile.visualfsm.Transition | ||
| import ru.kontur.mobile.visualfsm.TransitionCallbacks | ||
|
|
||
| class LogTransitionCallbacks<STATE : State>( |
There was a problem hiding this comment.
Похоже не дописана реализация
| } | ||
| } | ||
|
|
||
| override fun e(message: String, exception: Exception, errorGroupId: String) { |
There was a problem hiding this comment.
А точно мы хотим целых 4 сообщения выдавать? Ещё и message 2 раза выводим
| import ru.kontur.mobile.visualfsm.TransitionCallbacks | ||
|
|
||
|
|
||
| class TransitionCallbacksAggregator<STATE : State>( |
There was a problem hiding this comment.
Не используется. Точно хотим оставить? Как будто пользователи сами в состоянии в случае необходимости написать агрегатор или декоратор
| @@ -63,6 +72,6 @@ interface TransitionCallbacks<STATE : State> { | |||
| */ | |||
| fun onMultipleTransitionError( | |||
There was a problem hiding this comment.
Обсуждали с тобой, что в этот колбэк метод было бы неплохо передать все подошедшие транзишены для отладки
| @@ -5,6 +5,15 @@ package ru.kontur.mobile.visualfsm | |||
| */ | |||
| interface TransitionCallbacks<STATE : State> { | |||
There was a problem hiding this comment.
И вот здесь если накинуть ACTION в дженерик параметры, то в реализациях можно будет when по экшену без каста делать
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.