Java version

[Desoroxxx]

Instead of removing the sound filter mod what about adding the Java version checker?

As using an old version of Java like the CF Launcher default will cause problems with Virtually every mods.

[Krutoy242]

No, it's not causing problems with "virtually every mod".
For 400+ mods tested only sounds filters crashed.

Since Sound Filters was safetly replaced by Sound Physics and there no mods that crash with CF launcher yet, I want to keep CFLauncher compatibility as long as I can.

[Desoroxxx]

It will not break compatibility with CF launcher, just simply tell the user that the Java version is severely outdated and link them to a nice guide on how to update it.

No, it's not causing problems with "virtually every mod".

Actually, it kind of does, increasingly actually, a crash is not the only type of problem you can see.
It could cause low fps, slowdowns, bugs, incompatibility, etc...

[Krutoy242]

It will not break compatibility with CF launcher

Isnt Java 1.8.0_51 version is hardcoded to CF Launcher, and no other versions can be run from CFL?

I saw that in DJ2 discord

[Krutoy242]

Like, the problem with Fancier Block Particles - when i moved from old 1.8.0_51 to 1.8.3xx nothing notable changed 🤷‍♂️

Through, some E2EE players report that new Java boost FPS. But not for everyone.

[Desoroxxx]

Like, the problem with Fancier Block Particles - when i moved from old 1.8.0_51 to 1.8.3xx nothing notable changed 🤷‍♂️

Yeah, the problem was not because of Java this time but it is an important troubleshooting step as it is causing many problems everywhere.

[Desoroxxx]

It will not break compatibility with CF launcher

Isnt Java 1.8.0_51 version is hardcoded to CF Launcher, and no other versions can be run from CFL?

I saw that in DJ2 discord

That's not true (For a long time now)

https://youtu.be/EGUsEq6HOd0

[Krutoy242]

Nice video, thanks for the link!

For the other "many problems everywhere", can you example few of them from popular 1.12 mods? Because I don't know any at all.

[Desoroxxx]

For the other "many problems everywhere", can you example few of them from popular 1.12 mods? Because I don't know any at all.

Well:

1. Mods that update uses more recent Java features that might have unpatched issues in the old JDK and that is showing increasingly recently (Especially in multithreading scenarios)
2. The old JDK has a quite a few memory leaks, which affects people with low ram
3. Then there are the invisible problems like random crashes that only happens sometimes but not others, bugs that happens randomly, and the also reduce performance

Each update that passes for mods will make new problems for the old JDK

[Krutoy242]

Ok, now I want to setup version checker.

I searched on CF "Java version checker", but only found old 1.7 MC version.
It's there a special mod for this?

[Desoroxxx]

https://beta.curseforge.com/minecraft/mc-mods/oldjavawarning

[Krutoy242]

Thank you!

[Krutoy242]

Wait, i just discovered, that E2E-E already have this mod!

Is that means that mod not working at all?

[Desoroxxx]

Is that means that mod not working at all?

The mod does not hardcode the required Java version for obvious reasons, so you need to check the config.

[Krutoy242]

Configs set to S:minJavaVersion=1.8.0_162
And still, people with 1.8.0_51 doesn't get errors.

[Desoroxxx]

Weird need to look into it

[Desoroxxx]

This as old Java detection built in as well as a plethora of other features and optimization that you will like.
https://www.curseforge.com/minecraft/mc-mods/valkyrie

If you are using Random Patches you must disable the patching of the Minecraft class in Random Patches config

[Krutoy242]

This as old Java detection built in as well as a plethora of other features and optimization that you will like.
https://www.curseforge.com/minecraft/mc-mods/valkyrie

If you are using Random Patches you must disable the patching of the Minecraft class in Random Patches config

I will consider to add this mod. Through, we already fixed Old Java Warning with Bansoukou