Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the cache of API key secrets #265

Open
guicassolato opened this issue Apr 26, 2022 · 0 comments
Open

Limit the cache of API key secrets #265

guicassolato opened this issue Apr 26, 2022 · 0 comments

Comments

@guicassolato
Copy link
Collaborator

Unlike evaluators' runtime cache, the caching of API key Secrets is virtually unlimited (or limited by the amount of resources available to the process only.) This is not ideal. Instead, Authorino should:

  1. provide a way to limit the number of API keys that is cached for a given AuthConfig API key evaluator; and/or
  2. provide a way to not cache in-memory API keys at all, by
    a. supporting external cache storage, or
    b. implementing Kubernetes Secret lookup at request-time.

2a is consistent with the overall plan for caching in Authorino started mainly with #239 and #247. On the other hand, it violates the practice/principle of keeping these secrets internal in the cluster.

2b might be tricky as the API key cannot be used for lookup; rather it is the value stored inside the secret. Perhaps Authorino API keys could evolve to App ID/App secret for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

No branches or pull requests

2 participants