Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about timer resolution increasing #530

Open
alkino opened this issue Feb 6, 2024 · 2 comments
Open

Question about timer resolution increasing #530

alkino opened this issue Feb 6, 2024 · 2 comments

Comments

@alkino
Copy link

alkino commented Feb 6, 2024

In this commit:
8605c92#diff-954e57c109f5357a835754e303d3cf1d914d61dbbb2642d5d7d0b5ba1f46f119

The timer resolution have been increased.
It seems that since this patch we need to add .ns to time.offset, time.duration and time.inclusive.duration.

This is not explicitly said in the Release message and there is still the previous way in the doc.

Did I miss something?

@daboehme
Copy link
Member

daboehme commented Feb 7, 2024

Hi @alkino, yes with the timer resolution increase we added a .ns to some of the internal time attribute names like time.offset and time.duration. This is handled transparently in the built-in config recipes like hatchet-region-profile, however if you're manually configuring Caliper with the CALI_SERVICES_ENABLE etc. variables and use cali-query to process the output you might need to make these adjustments. Apologies for the inconvenience!

Good point about the documentation though, I'll check and fix instances where I may have missed this.

@alkino
Copy link
Author

alkino commented Feb 8, 2024

I will add something new here: #458

Would be good to modify the release note here: https://github.com/LLNL/Caliper/releases/tag/v2.10.0

To tell the breakage for both of those features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants