diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml index 525de0c..3dfd08d 100644 --- a/.github/workflows/verify.yml +++ b/.github/workflows/verify.yml @@ -10,15 +10,15 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2.3.4 - - name: Set up JDK 8 - uses: actions/setup-java@v2 + - uses: actions/checkout@v4 + - name: Set up JDK 11 + uses: actions/setup-java@v4 with: distribution: adopt - java-version: 8 + java-version: 11 - name: Grant execute permission for gradlew run: chmod +x gradlew - name: Build with Gradle run: ./gradlew --build-cache shadowJar - name: Test with Gradle - run: ./gradlew test \ No newline at end of file + run: ./gradlew test diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..ccab28b --- /dev/null +++ b/.gitignore @@ -0,0 +1,32 @@ +.gradle +**/build/ +!src/**/build/ +gradle.properties + +# Ignore Gradle GUI configuration +gradle-app.setting + +# Avoid ignoring Gradle wrapper jar file (.jar files are usually ignored) +!gradle-wrapper.jar + +# Cache of project +.gradletasknamecache + +# User-specific stuff +.idea/ +*.iml + +# CMake +cmake-build-*/ + +# Maven +target/ +pom.xml.tag +pom.xml.releaseBackup +pom.xml.versionsBackup +pom.xml.next +release.properties +dependency-reduced-pom.xml +buildNumber.properties +.mvn/timing.properties +.mvn/wrapper/maven-wrapper.jar diff --git a/LandLordMap-bluemap/build.gradle.kts b/LandLordMap-bluemap/build.gradle.kts index a6fed07..3883994 100644 --- a/LandLordMap-bluemap/build.gradle.kts +++ b/LandLordMap-bluemap/build.gradle.kts @@ -1,13 +1,10 @@ plugins { id("biz.princeps.java-conventions") - id("com.github.johnrengelman.shadow") version "7.0.0" + id("com.github.johnrengelman.shadow") version "8.1.1" } dependencies { implementation(project(":LandLordMap-core")) - compileOnly("org.spigotmc:spigot-api:1.16.5-R0.1-SNAPSHOT") - compileOnly("biz.princeps:landlord-core:4.360") - compileOnly("de.eldoria:eldo-util:1.11.0-DEV") compileOnly("com.github.BlueMap-Minecraft:BlueMapAPI:v1.7.0") } @@ -40,4 +37,4 @@ tasks { events("passed", "skipped", "failed") } } -} \ No newline at end of file +} diff --git a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/LLBlueMap.java b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/LLBlueMap.java index a49e0e5..2498574 100644 --- a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/LLBlueMap.java +++ b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/LLBlueMap.java @@ -15,43 +15,39 @@ public class LLBlueMap extends JavaPlugin { - ILandLord landLordAPI; - Configuration configuration; - BlueMapIntegration blueMapIntegration; + private ILandLord landLordAPI; + private Configuration configuration; + private BlueMapIntegration blueMapIntegration; @Override public void onEnable() { - logToConsole(Level.INFO, "Loading configuration..."); + getLogger().info( "Loading configuration..."); saveDefaultConfig(); configuration = new Configuration(this); blueMapIntegration = new BlueMapIntegration(this); - final PluginManager pluginManager = Bukkit.getPluginManager(); - logToConsole(Level.INFO, "Loading listeners..."); + PluginManager pluginManager = getServer().getPluginManager(); + getLogger().info("Loading listeners..."); pluginManager.registerEvents(new LandlordListener(this, blueMapIntegration), this); - logToConsole(Level.INFO, "Loading commands..."); + getLogger().info( "Loading commands..."); PrincepsLib.getCommandManager().registerCommand(new Commands(this)); - logToConsole(Level.INFO, "Loading APIs..."); + getLogger().info( "Loading APIs..."); landLordAPI = (ILandLord) pluginManager.getPlugin("Landlord"); BlueMapAPI.onEnable(blueMapAPI -> { - logToConsole(Level.INFO, "BlueMap integration is initializing..."); + getLogger().info( "BlueMap integration is initializing..."); blueMapIntegration.hookBlueMap(blueMapAPI); - logToConsole(Level.INFO, "BlueMap integration has been successfully enabled/reloaded!"); + getLogger().info( "BlueMap integration has been successfully enabled/reloaded!"); }); } @Override public void onDisable() { BlueMapAPI.getInstance().ifPresent(blueMapAPI -> blueMapIntegration.unhookBlueMap(blueMapAPI)); - logToConsole(Level.INFO, "Thank you :)"); - } - - public void logToConsole(Level level, String message) { - Bukkit.getLogger().log(level, "[" + getName() + "] " + message); + getLogger().info("Thank you :)"); } public Configuration getConfiguration() { diff --git a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/commands/CommandReload.java b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/commands/CommandReload.java index c2969d8..b76757e 100644 --- a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/commands/CommandReload.java +++ b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/commands/CommandReload.java @@ -26,7 +26,7 @@ public void onCommand(Properties properties, Arguments arguments) { plugin.reloadConfig(); plugin.getConfiguration().load(); - final Optional optionalBlueMapAPI = BlueMapAPI.getInstance(); + Optional optionalBlueMapAPI = BlueMapAPI.getInstance(); if (optionalBlueMapAPI.isPresent()) { plugin.getBlueMapIntegration().hookBlueMap(optionalBlueMapAPI.get()); properties.sendMessage("§aConfig successfully reloaded!"); @@ -35,4 +35,4 @@ public void onCommand(Properties properties, Arguments arguments) { } } -} \ No newline at end of file +} diff --git a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/commands/Commands.java b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/commands/Commands.java index 3942cab..562c1f8 100644 --- a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/commands/Commands.java +++ b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/commands/Commands.java @@ -22,12 +22,12 @@ public Commands(LLBlueMap plugin) { plugin.getConfig().getStringList("CommandSettings.Main.aliases").toArray(new String[]{})); this.plugin = plugin; - this.addSubcommand(new CommandReload(plugin)); + addSubcommand(new CommandReload(plugin)); } @Override public List tabComplete(CommandSender sender, String alias, String[] args) throws IllegalArgumentException { - final List completions = new ArrayList<>(); + List completions = new ArrayList<>(); if (args.length == 1) { subCommandMap.forEach((name, subCommand) -> { @@ -45,4 +45,4 @@ public List tabComplete(CommandSender sender, String alias, String[] arg public void onCommand(Properties properties, Arguments arguments) { } -} \ No newline at end of file +} diff --git a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/config/Configuration.java b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/config/Configuration.java index c7d2d22..55ab4b0 100644 --- a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/config/Configuration.java +++ b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/config/Configuration.java @@ -34,7 +34,7 @@ public Configuration(LLBlueMap plugin) { } public void load() { - final FileConfiguration config = plugin.getConfig(); + FileConfiguration config = plugin.getConfig(); updateTaskFrequency = config.getLong("update-task-frequency"); maxProcessedPerUpdate = config.getInt("max-processed-per-update"); diff --git a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/BlueMapIntegration.java b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/BlueMapIntegration.java index ebe879b..579b29d 100644 --- a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/BlueMapIntegration.java +++ b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/BlueMapIntegration.java @@ -30,9 +30,9 @@ public class BlueMapIntegration { public BlueMapIntegration(LLBlueMap plugin) { this.plugin = plugin; - this.config = plugin.getConfiguration(); + config = plugin.getConfiguration(); - this.queue = new ConcurrentHashMap<>(); + queue = new ConcurrentHashMap<>(); } private MarkerSet buildMarkerSet(MarkerAPI markerAPI) { @@ -42,28 +42,28 @@ private MarkerSet buildMarkerSet(MarkerAPI markerAPI) { public void hookBlueMap(BlueMapAPI blueMapAPI) { Bukkit.getScheduler().runTaskAsynchronously(plugin, bukkitTask -> { try { - final MarkerAPI markerAPI = blueMapAPI.getMarkerAPI(); - plugin.logToConsole(Level.INFO, "Loading Landlord markers..."); + MarkerAPI markerAPI = blueMapAPI.getMarkerAPI(); + plugin.getLogger().info("Loading Landlord markers..."); - final MarkerSet markerSet = buildMarkerSet(markerAPI); - final int size = markerSet.getMarkers().size(); + MarkerSet markerSet = buildMarkerSet(markerAPI); + int size = markerSet.getMarkers().size(); - plugin.logToConsole(Level.INFO, "Updating Landlord markers..."); + plugin.getLogger().info("Updating Landlord markers..."); markerSet.setLabel(config.getMarkerSetLabel()); markerSet.setDefaultHidden(config.isMarkerSetDefaultHidden()); markerSet.setToggleable(config.isMarkerSetToggleable()); if (size == 0) { - plugin.logToConsole(Level.WARNING, "Landlord markers not found!"); + plugin.getLogger().warning("Landlord markers not found!"); importLands(blueMapAPI, markerAPI, markerSet); } else { - plugin.logToConsole(Level.INFO, size + " Landlord markers found!"); + plugin.getLogger().info(size + " Landlord markers found!"); markerAPI.save(); } - plugin.logToConsole(Level.INFO, "Loading update task..."); + plugin.getLogger().info("Loading update task..."); initUpdateTask(); } catch (IOException e) { - e.printStackTrace(); + plugin.getLogger().log(Level.SEVERE, "Could not retrieve marker api", e); } }); } @@ -71,14 +71,14 @@ public void hookBlueMap(BlueMapAPI blueMapAPI) { public void unhookBlueMap(BlueMapAPI blueMapAPI) { try { updateTask.cancel(); - final MarkerAPI markerAPI = blueMapAPI.getMarkerAPI(); + MarkerAPI markerAPI = blueMapAPI.getMarkerAPI(); - final Set ownedLands = plugin.getLandLordAPI().getWGManager().getRegions(); - plugin.logToConsole(Level.WARNING, "Checking " + ownedLands.size() + " lands and processing " + queue.size() + " remaining updates, this could take a while..."); + Set ownedLands = plugin.getLandLordAPI().getWGManager().getRegions(); + plugin.getLogger().warning("Checking " + ownedLands.size() + " lands and processing " + queue.size() + " remaining updates, this could take a while..."); for (IOwnedLand ownedLand : plugin.getLandLordAPI().getWGManager().getRegions()) { - final OfflinePlayer offlinePlayer = Bukkit.getOfflinePlayer(ownedLand.getOwner()); - final Instant lastPlayed = Instant.ofEpochMilli(offlinePlayer.getLastPlayed()); + OfflinePlayer offlinePlayer = Bukkit.getOfflinePlayer(ownedLand.getOwner()); + Instant lastPlayed = Instant.ofEpochMilli(offlinePlayer.getLastPlayed()); if (lastPlayed.isBefore(Instant.now().minus(config.getMarkerSetLifetime(), ChronoUnit.DAYS))) { enqueueLand(ownedLand, UpdateReason.UNCLAIM); @@ -86,7 +86,7 @@ public void unhookBlueMap(BlueMapAPI blueMapAPI) { } processQueue(blueMapAPI, markerAPI, buildMarkerSet(markerAPI), Integer.MAX_VALUE); } catch (IOException e) { - e.printStackTrace(); + plugin.getLogger().log(Level.SEVERE, "Could not retrieve marker api", e); } } @@ -97,17 +97,17 @@ public void initUpdateTask() { updateTask = Bukkit.getScheduler().runTaskTimerAsynchronously(plugin, () -> BlueMapAPI.getInstance().ifPresent(blueMapAPI -> { try { - final MarkerAPI markerAPI = blueMapAPI.getMarkerAPI(); + MarkerAPI markerAPI = blueMapAPI.getMarkerAPI(); processQueue(blueMapAPI, markerAPI, buildMarkerSet(markerAPI), config.getMaxProcessedPerUpdate()); } catch (IOException e) { - e.printStackTrace(); + plugin.getLogger().log(Level.SEVERE, "Could not retrieve marker api", e); } }), config.getUpdateTaskFrequency(), config.getUpdateTaskFrequency()); } private void importLands(BlueMapAPI blueMapAPI, MarkerAPI markerAPI, MarkerSet markerSet) { - final Set ownedLands = plugin.getLandLordAPI().getWGManager().getRegions(); - plugin.logToConsole(Level.WARNING, "Importing " + ownedLands.size() + " lands, this could take a while..."); + Set ownedLands = plugin.getLandLordAPI().getWGManager().getRegions(); + plugin.getLogger().warning("Importing " + ownedLands.size() + " lands, this could take a while..."); // final BlueMapIsland blueMapIsland = new BlueMapIsland(plugin, plugin.getLandLordAPI().getWGManager().getRegion("world_1429_-2113")); // @@ -145,8 +145,8 @@ private void importLands(BlueMapAPI blueMapAPI, MarkerAPI markerAPI, MarkerSet m // } for (IOwnedLand ownedLand : plugin.getLandLordAPI().getWGManager().getRegions()) { - final OfflinePlayer offlinePlayer = Bukkit.getOfflinePlayer(ownedLand.getOwner()); - final Instant lastPlayed = Instant.ofEpochMilli(offlinePlayer.getLastPlayed()); + OfflinePlayer offlinePlayer = Bukkit.getOfflinePlayer(ownedLand.getOwner()); + Instant lastPlayed = Instant.ofEpochMilli(offlinePlayer.getLastPlayed()); if (lastPlayed.isAfter(Instant.now().minus(config.getMarkerSetLifetime(), ChronoUnit.DAYS))) { enqueueLand(ownedLand, UpdateReason.CLAIM); @@ -157,20 +157,15 @@ private void importLands(BlueMapAPI blueMapAPI, MarkerAPI markerAPI, MarkerSet m } public void enqueueLand(IOwnedLand ownedLand, UpdateReason updateReason) { - if (ownedLand == null || ownedLand.getOwner() == null) - return; + if (ownedLand == null || ownedLand.getOwner() == null) return; queue.compute(ownedLand, (queuedOwnedLand, queuedUpdateReason) -> { - if (queuedUpdateReason == null) { - return updateReason; - } + if (queuedUpdateReason == null) return updateReason; switch (queuedUpdateReason) { case CLAIM: case UNCLAIM: - if (updateReason == UpdateReason.MANAGE) { - return queuedUpdateReason; - } + if (updateReason == UpdateReason.MANAGE) return queuedUpdateReason; default: return updateReason; } @@ -181,7 +176,7 @@ private void processQueue(BlueMapAPI blueMapAPI, MarkerAPI markerAPI, MarkerSet int iterations = 0; for (Iterator> iterator = queue.entrySet().iterator(); iterator.hasNext() && iterations < limit; ) { - final Map.Entry entry = iterator.next(); + Map.Entry entry = iterator.next(); new BlueMapLand(plugin, entry.getKey()).process(blueMapAPI, markerSet, entry.getValue()); @@ -189,13 +184,13 @@ private void processQueue(BlueMapAPI blueMapAPI, MarkerAPI markerAPI, MarkerSet iterations++; } - if (iterations == 0) - return; + if (iterations == 0) return; + try { markerAPI.save(); } catch (IOException e) { - e.printStackTrace(); + plugin.getLogger().log(Level.SEVERE, "Could not save to marker api", e); } } -} \ No newline at end of file +} diff --git a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/BlueMapLand.java b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/BlueMapLand.java index b3f2620..fcfa519 100644 --- a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/BlueMapLand.java +++ b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/BlueMapLand.java @@ -31,19 +31,19 @@ public class BlueMapLand { private final String members; public BlueMapLand(LLBlueMap plugin, IOwnedLand ownedLand) { - this.config = plugin.getConfiguration(); + config = plugin.getConfiguration(); - this.id = ownedLand.getName(); - this.label = config.getBlueMapLandLabel().replace("%ID%", id); - this.world = ownedLand.getWorld().getName(); + id = ownedLand.getName(); + label = config.getBlueMapLandLabel().replace("%ID%", id); + world = ownedLand.getWorld().getName(); - final Chunk chunk = ownedLand.getChunk(); - this.firstCorner = new Vector2d(chunk.getX() << 4, chunk.getZ() << 4); - this.secondCorner = new Vector2d((chunk.getX() << 4) + 16, (chunk.getZ() << 4) + 16); + Chunk chunk = ownedLand.getChunk(); + firstCorner = new Vector2d(chunk.getX() << 4, chunk.getZ() << 4); + secondCorner = new Vector2d((chunk.getX() << 4) + 16, (chunk.getZ() << 4) + 16); - this.owner = ownedLand.getOwner(); - this.owners = ownedLand.getOwnersString(); - this.members = ownedLand.getMembersString(); + owner = ownedLand.getOwner(); + owners = ownedLand.getOwnersString(); + members = ownedLand.getMembersString(); } public String getId() { @@ -83,11 +83,11 @@ public void process(BlueMapAPI blueMapAPI, MarkerSet markerSet, UpdateReason upd } public ObjectMarker add(BlueMapAPI blueMapAPI, MarkerSet markerSet) { - final Optional optionalBlueMapMap = blueMapAPI.getMap(world); + Optional optionalBlueMapMap = blueMapAPI.getMap(world); if (!optionalBlueMapMap.isPresent()) return null; - final ShapeMarker marker = markerSet.createShapeMarker( + ShapeMarker marker = markerSet.createShapeMarker( id, optionalBlueMapMap.get(), Shape.createRect(firstCorner, secondCorner), @@ -98,12 +98,12 @@ public ObjectMarker add(BlueMapAPI blueMapAPI, MarkerSet markerSet) { marker.setLineColor(config.getBlueMapLandLineColor()); marker.setLineWidth(config.getBlueMapLandLineWidth()); - final Color fillColor; + Color fillColor; if (config.isBlueMapLandOwnerBased()) { - final Color playerColor = new Color((int) owner.getMostSignificantBits()); + Color playerColor = new Color((int) owner.getMostSignificantBits()); fillColor = new Color(playerColor.getRed(), playerColor.getGreen(), playerColor.getBlue(), config.getBlueMapLandFillAlpha()); } else { - final Color configColor = config.getBlueMapLandFillColor(); + Color configColor = config.getBlueMapLandFillColor(); fillColor = new Color(configColor.getRed(), configColor.getGreen(), configColor.getBlue(), config.getBlueMapLandFillAlpha()); } marker.setFillColor(fillColor); @@ -119,7 +119,7 @@ public void remove(MarkerSet markerSet) { } public void update(BlueMapAPI blueMapAPI, MarkerSet markerSet) { - final ObjectMarker marker = (ObjectMarker) markerSet.getMarker(id).orElse(add(blueMapAPI, markerSet)); + ObjectMarker marker = (ObjectMarker) markerSet.getMarker(id).orElse(add(blueMapAPI, markerSet)); if (marker == null) return; diff --git a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/island/BlueMapIsland.java b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/island/BlueMapIsland.java index f905cbe..420a939 100644 --- a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/island/BlueMapIsland.java +++ b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/integration/island/BlueMapIsland.java @@ -17,8 +17,8 @@ public class BlueMapIsland { public BlueMapIsland(LLBlueMap plugin, IOwnedLand ownedLand) { this.plugin = plugin; - this.owner = ownedLand.getOwner(); - this.lands = new HashMap<>(); + owner = ownedLand.getOwner(); + lands = new HashMap<>(); recursiveSearch(ownedLand); } @@ -35,8 +35,8 @@ private void recursiveSearch(IOwnedLand center) { if (center == null || lands.containsKey(center)) return; - final IOwnedLand[] adjacents = plugin.getLandLordAPI().getWGManager().getSurroundingsOwner(center, owner); - final Set directions = new HashSet<>(); + IOwnedLand[] adjacents = plugin.getLandLordAPI().getWGManager().getSurroundingsOwner(center, owner); + Set directions = EnumSet.noneOf(Direction.class); for (Direction direction : Direction.values()) { if (adjacents[direction.getIndex()] == null) { @@ -51,17 +51,17 @@ private void recursiveSearch(IOwnedLand center) { } public Vector2d[] getBorderPoints() { - final Set points = new LinkedHashSet<>(); + Set points = new LinkedHashSet<>(); for (Map.Entry> entry : lands.entrySet()) { - final Set directions = entry.getValue(); + Set directions = entry.getValue(); if (directions.isEmpty()) continue; - final IOwnedLand iOwnedLand = entry.getKey(); - final Chunk chunk = iOwnedLand.getChunk(); - final int chunkX = chunk.getX(); - final int chunkZ = chunk.getZ(); + IOwnedLand iOwnedLand = entry.getKey(); + Chunk chunk = iOwnedLand.getChunk(); + int chunkX = chunk.getX(); + int chunkZ = chunk.getZ(); for (Direction direction : directions) { points.add(direction.getFirstPoint(chunkX, chunkZ)); diff --git a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/listeners/LandlordListener.java b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/listeners/LandlordListener.java index 08a15ec..601f90f 100644 --- a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/listeners/LandlordListener.java +++ b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/listeners/LandlordListener.java @@ -27,17 +27,18 @@ public class LandlordListener implements Listener { public LandlordListener(LLBlueMap plugin, BlueMapIntegration blueMapIntegration) { this.plugin = plugin; - this.config = plugin.getConfiguration(); + config = plugin.getConfiguration(); this.blueMapIntegration = blueMapIntegration; } @EventHandler(ignoreCancelled = true, priority = EventPriority.MONITOR) public void onAsyncPlayerPreLoginEvent(AsyncPlayerPreLoginEvent event) { - if (event.getLoginResult() != AsyncPlayerPreLoginEvent.Result.ALLOWED) + if (event.getLoginResult() != AsyncPlayerPreLoginEvent.Result.ALLOWED){ return; - final UUID uuid = event.getUniqueId(); - final OfflinePlayer offlinePlayer = Bukkit.getOfflinePlayer(uuid); - final Instant lastPlayed = Instant.ofEpochMilli(offlinePlayer.getLastPlayed()); + } + UUID uuid = event.getUniqueId(); + OfflinePlayer offlinePlayer = Bukkit.getOfflinePlayer(uuid); + Instant lastPlayed = Instant.ofEpochMilli(offlinePlayer.getLastPlayed()); if (lastPlayed.isBefore(Instant.now().minus(config.getMarkerSetLifetime(), ChronoUnit.DAYS))) { for (IOwnedLand ownedLand : plugin.getLandLordAPI().getWGManager().getRegions(uuid)) { @@ -58,9 +59,9 @@ public void onLandUnclaimEvent(LandUnclaimEvent event) { @EventHandler(ignoreCancelled = true, priority = EventPriority.MONITOR) public void onLandManageEvent(LandManageEvent event) { - if (!event.getFlagChanged().equals("FRIENDS")) + if (!"FRIENDS".equals(event.getFlagChanged())) return; blueMapIntegration.enqueueLand(event.getLand(), UpdateReason.MANAGE); } -} \ No newline at end of file +} diff --git a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/utils/Constants.java b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/utils/Constants.java index cf0622a..552986e 100644 --- a/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/utils/Constants.java +++ b/LandLordMap-bluemap/src/main/java/biz/princeps/landlordmap/bluemap/utils/Constants.java @@ -1,6 +1,9 @@ package biz.princeps.landlordmap.bluemap.utils; -public class Constants { +public final class Constants { + private Constants() { + throw new UnsupportedOperationException("This is a utility class."); + } public static final String MARKER_SET_ID = "LandLordMap"; diff --git a/LandLordMap-core/build.gradle.kts b/LandLordMap-core/build.gradle.kts index 1f80a1c..ca5bb4a 100644 --- a/LandLordMap-core/build.gradle.kts +++ b/LandLordMap-core/build.gradle.kts @@ -3,9 +3,9 @@ plugins { } dependencies { - compileOnly("org.spigotmc:spigot-api:1.16.5-R0.1-SNAPSHOT") - compileOnly("biz.princeps:landlord-core:4.360") - compileOnly("de.eldoria:eldo-util:1.11.0-DEV") + api("org.spigotmc", "spigot-api", "1.16.5-R0.1-SNAPSHOT") + api("biz.princeps", "landlord-core", "4.363") + api("de.eldoria", "eldo-util", "1.11.0-DEV") } -description = "LandLordMap-core" \ No newline at end of file +description = "LandLordMap-core" diff --git a/LandLordMap-dynmap/build.gradle.kts b/LandLordMap-dynmap/build.gradle.kts index 16a555e..358c8a7 100644 --- a/LandLordMap-dynmap/build.gradle.kts +++ b/LandLordMap-dynmap/build.gradle.kts @@ -1,13 +1,10 @@ plugins { id("biz.princeps.java-conventions") - id("com.github.johnrengelman.shadow") version "7.0.0" + id("com.github.johnrengelman.shadow") version "8.1.1" } dependencies { implementation(project(":LandLordMap-core")) - compileOnly("org.spigotmc:spigot-api:1.16.5-R0.1-SNAPSHOT") - compileOnly("biz.princeps:landlord-core:4.360") - compileOnly("de.eldoria:eldo-util:1.11.0-DEV") compileOnly("us.dynmap:dynmap-api:3.0") implementation("org.codemc.worldguardwrapper:worldguardwrapper:1.2.0-SNAPSHOT") } @@ -45,4 +42,4 @@ tasks { events("passed", "skipped", "failed") } } -} \ No newline at end of file +} diff --git a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/FlatFileStorage.java b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/FlatFileStorage.java index 00d7602..b7900f6 100644 --- a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/FlatFileStorage.java +++ b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/FlatFileStorage.java @@ -14,6 +14,7 @@ import java.io.File; import java.io.IOException; import java.util.*; +import java.util.logging.Level; public class FlatFileStorage { @@ -42,7 +43,7 @@ public void init() { try { customConfig.load(customConfigFile); } catch (IOException | InvalidConfigurationException e) { - e.printStackTrace(); + pl.getLogger().log(Level.SEVERE, "coult not load config", e); } } @@ -58,7 +59,7 @@ public Map getIsles() { for (World world : Bukkit.getWorlds()) { ConfigurationSection section = customConfig.getConfigurationSection(world.getName()); - if (section == null || section.getKeys(false).size() == 0) { + if (section == null || section.getKeys(false).isEmpty()) { continue; } IsleGenerator gen = new IsleGenerator(pl, world); @@ -132,4 +133,4 @@ public synchronized void save() { e.printStackTrace(); } } -} \ No newline at end of file +} diff --git a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/LLDynmap.java b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/LLDynmap.java index ed73821..9504e5d 100644 --- a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/LLDynmap.java +++ b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/LLDynmap.java @@ -37,26 +37,26 @@ public void onLoad() { @Override public void onEnable() { try { - this.dynMap = (DynmapAPI) getServer().getPluginManager().getPlugin("dynmap"); + dynMap = (DynmapAPI) getServer().getPluginManager().getPlugin("dynmap"); } catch (NoClassDefFoundError ex) { getLogger().warning("dynMap is missing! Couldn't start LLDM!!!"); - this.getPluginLoader().disablePlugin(this); + getPluginLoader().disablePlugin(this); return; } try { - this.api = (ILandLord) getServer().getPluginManager().getPlugin("Landlord"); + api = (ILandLord) getServer().getPluginManager().getPlugin("Landlord"); } catch (NoClassDefFoundError ex) { getLogger().warning("Landlord missing! Please make sure to install the latest version of Landlord!"); - this.getPluginLoader().disablePlugin(this); + getPluginLoader().disablePlugin(this); return; } initMarkers(); flatFileStorage = new FlatFileStorage(this); - this.playerManager = new PlayerManager(this); - this.worldGuardHandler = api.getWGManager(); + playerManager = new PlayerManager(this); + worldGuardHandler = api.getWGManager(); - this.landHelper = new LandHelper(this, worldGuardHandler); - this.isleGenerator = flatFileStorage.getIsles(); + landHelper = new LandHelper(this, worldGuardHandler); + isleGenerator = flatFileStorage.getIsles(); PrincepsLib.getCommandManager().registerCommand(new Commands(this)); @@ -70,7 +70,7 @@ public void onDisable() { } private void initListener() { - this.getServer().getPluginManager().registerEvents(new LandlordListener(this), this); + getServer().getPluginManager().registerEvents(new LandlordListener(this), this); } /** @@ -126,7 +126,7 @@ public Map getIsleGenerator() { public void debug(String message) { if (getConfig().getBoolean("debugging", false)) - this.getLogger().info(message); + getLogger().info(message); } public String getMessage(String path) { diff --git a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/LandHelper.java b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/LandHelper.java index 8432af6..fe8dc94 100644 --- a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/LandHelper.java +++ b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/LandHelper.java @@ -27,7 +27,7 @@ public class LandHelper { public LandHelper(LLDynmap p, IWorldGuardManager wg) { this.wg = wg; - this.pl = p; + pl = p; } /** diff --git a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/PlayerManager.java b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/PlayerManager.java index e0f788b..5dfd218 100644 --- a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/PlayerManager.java +++ b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/PlayerManager.java @@ -36,7 +36,7 @@ public PlayerManager(LLDynmap pl) { pl.getLogger().warning("Could not create data.yml!"); } } - this.data = YamlConfiguration.loadConfiguration(file); + data = YamlConfiguration.loadConfiguration(file); } /** diff --git a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Color.java b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Color.java index 45112df..9e12495 100644 --- a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Color.java +++ b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Color.java @@ -21,7 +21,7 @@ public Color(LLDynmap pl) { Sets.newHashSet(pl.getConfig().getStringList("CommandSettings.color.permissions")), Sets.newHashSet(pl.getConfig().getStringList("CommandSettings.color.aliases"))); this.pl = pl; - this.wgm = pl.getWorldGuardHandler(); + wgm = pl.getWorldGuardHandler(); } @Override @@ -35,10 +35,10 @@ public void onCommand(Properties properties, Arguments arguments) { return; } - long hex = 0xffffff; + long hex; try { hex = Long.parseLong(arguments.get(0), 16); - } catch (Exception ex) { + } catch (NumberFormatException ex) { properties.sendMessage(pl.getMessage("CommandSettings.color.messages.wrongformat")); return; } diff --git a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Commands.java b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Commands.java index 06374f8..174eb0f 100644 --- a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Commands.java +++ b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Commands.java @@ -24,10 +24,10 @@ public Commands(LLDynmap pl) { Sets.newHashSet(pl.getConfig().getStringList("CommandSettings.Main.permissions")), pl.getConfig().getStringList("CommandSettings.Main.aliases").toArray(new String[]{})); this.pl = pl; - this.wgm = pl.getWorldGuardHandler(); + wgm = pl.getWorldGuardHandler(); - this.addSubcommand(new Import(pl)); - this.addSubcommand(new Color(pl)); + addSubcommand(new Import(pl)); + addSubcommand(new Color(pl)); } @Override @@ -43,7 +43,7 @@ public List tabComplete(CommandSender sender, String alias, String[] arg } if (args.length == 2) { - if (args[0].equalsIgnoreCase("import")) { + if ("import".equalsIgnoreCase(args[0])) { Collections.addAll(tabReturn, "all", "wg", "ll"); } } diff --git a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Import.java b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Import.java index 92cc606..a0b5140 100644 --- a/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Import.java +++ b/LandLordMap-dynmap/src/main/java/biz/princeps/landlordmap/dynmap/commands/Import.java @@ -35,7 +35,7 @@ public Import(LLDynmap pl) { Sets.newHashSet(pl.getConfig().getStringList("CommandSettings.import.permissions")), Sets.newHashSet(pl.getConfig().getStringList("CommandSettings.import.aliases"))); this.pl = pl; - this.wgm = pl.getWorldGuardHandler(); + wgm = pl.getWorldGuardHandler(); defaultVal = pl.getConfig().getBoolean("WorldGuard.color.default"); showflag = pl.getConfig().getBoolean("WorldGuard.color.show_flag"); @@ -44,7 +44,7 @@ public Import(LLDynmap pl) { @Override public void onCommand(Properties properties, Arguments arguments) { //lldm import