From e35977104b5f62a636527de24829cf501aa340ba Mon Sep 17 00:00:00 2001
From: LuisFelipeCoelho <luisfelipefuc@gmail.com>
Date: Fri, 28 Jul 2023 13:44:32 +0200
Subject: [PATCH] retrieve skipZMiddleBin from group

---
 Core/include/Acts/Seeding/BinnedSPGroup.hpp | 12 +++++-------
 Core/include/Acts/Seeding/BinnedSPGroup.ipp | 17 +++++++----------
 2 files changed, 12 insertions(+), 17 deletions(-)

diff --git a/Core/include/Acts/Seeding/BinnedSPGroup.hpp b/Core/include/Acts/Seeding/BinnedSPGroup.hpp
index 8fbd9dae995..062d76811ab 100644
--- a/Core/include/Acts/Seeding/BinnedSPGroup.hpp
+++ b/Core/include/Acts/Seeding/BinnedSPGroup.hpp
@@ -39,9 +39,9 @@ class BinnedSPGroupIterator {
  public:
   // Never take ownerships
   BinnedSPGroupIterator(BinnedSPGroup<external_spacepoint_t>&& group,
-                        std::size_t, std::size_t skipZMiddleBin = 0) = delete;
+                        std::size_t) = delete;
   BinnedSPGroupIterator(BinnedSPGroup<external_spacepoint_t>& group,
-                        std::size_t index, std::size_t skipZMiddleBin = 0);
+                        std::size_t index);
 
   BinnedSPGroupIterator(const BinnedSPGroupIterator&) = delete;
   BinnedSPGroupIterator& operator=(const BinnedSPGroupIterator&) = delete;
@@ -70,8 +70,6 @@ class BinnedSPGroupIterator {
   std::array<std::size_t, 2> m_max_localBins;
   // Current Local Bins
   std::array<std::size_t, 2> m_current_localBins{0, 0};
-  // Number of Z bins to skip the search for middle SP
-  std::size_t m_skipZMiddleBin;
 };
 
 /// @c BinnedSPGroup Provides access to begin and end BinnedSPGroupIterator
@@ -111,9 +109,9 @@ class BinnedSPGroup {
   BinnedSPGroupIterator<external_spacepoint_t> begin();
   BinnedSPGroupIterator<external_spacepoint_t> end();
 
-  Acts::SpacePointGrid<external_spacepoint_t>& grid() {
-    return *m_grid.get();
-  }
+  Acts::SpacePointGrid<external_spacepoint_t>& grid() { return *m_grid.get(); }
+
+  std::size_t skipZMiddleBin() { return m_skipZMiddleBin; }
 
  private:
   // grid with ownership of all InternalSpacePoint
diff --git a/Core/include/Acts/Seeding/BinnedSPGroup.ipp b/Core/include/Acts/Seeding/BinnedSPGroup.ipp
index 478cf89fc94..b3b9f7167f7 100644
--- a/Core/include/Acts/Seeding/BinnedSPGroup.ipp
+++ b/Core/include/Acts/Seeding/BinnedSPGroup.ipp
@@ -12,13 +12,10 @@
 
 template <typename external_spacepoint_t>
 Acts::BinnedSPGroupIterator<external_spacepoint_t>::BinnedSPGroupIterator(
-    Acts::BinnedSPGroup<external_spacepoint_t>& group, std::size_t index,
-    std::size_t skipZMiddleBin)
-    : m_group(group),
-      m_max_localBins(m_group->m_grid->numLocalBins()),
-      m_skipZMiddleBin(skipZMiddleBin) {
+    Acts::BinnedSPGroup<external_spacepoint_t>& group, std::size_t index)
+    : m_group(group), m_max_localBins(m_group->m_grid->numLocalBins()) {
   m_max_localBins[INDEX::PHI] += 1;
-  m_current_localBins[INDEX::Z] = m_skipZMiddleBin;
+  m_current_localBins[INDEX::Z] = m_group->skipZMiddleBin();
   if (index == m_group->m_grid->size()) {
     m_current_localBins = m_max_localBins;
   } else {
@@ -34,7 +31,7 @@ Acts::BinnedSPGroupIterator<external_spacepoint_t>::operator++() {
   // if we were on the edge, go up one phi bin and reset z bin
   if (++m_current_localBins[INDEX::Z] == m_max_localBins[INDEX::Z]) {
     ++m_current_localBins[INDEX::PHI];
-    m_current_localBins[INDEX::Z] = m_skipZMiddleBin;
+    m_current_localBins[INDEX::Z] = m_group->skipZMiddleBin();
   }
 
   // Get the next not-empty bin in the grid
@@ -109,7 +106,7 @@ Acts::BinnedSPGroupIterator<external_spacepoint_t>::findNotEmptyBin() {
       return;
     }
     // Reset z-index
-    m_current_localBins[INDEX::Z] = m_skipZMiddleBin;
+    m_current_localBins[INDEX::Z] = m_group->skipZMiddleBin();
   }
 
   // Could find nothing ... setting this to end()
@@ -242,11 +239,11 @@ inline size_t Acts::BinnedSPGroup<external_spacepoint_t>::size() const {
 template <typename external_spacepoint_t>
 inline Acts::BinnedSPGroupIterator<external_spacepoint_t>
 Acts::BinnedSPGroup<external_spacepoint_t>::begin() {
-  return {*this, 0, m_skipZMiddleBin};
+  return {*this, 0};
 }
 
 template <typename external_spacepoint_t>
 inline Acts::BinnedSPGroupIterator<external_spacepoint_t>
 Acts::BinnedSPGroup<external_spacepoint_t>::end() {
-  return {*this, m_grid->size(), 0};
+  return {*this, m_grid->size()};
 }