Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make libmdaxdr and libdcd cython classes use pxd format so they can be cimported #3907

Closed
hmacdope opened this issue Nov 6, 2022 · 2 comments
Assignees
Labels
CZI-performance performance track of CZIEOSS4 grant

Comments

@hmacdope
Copy link
Member

hmacdope commented Nov 6, 2022

Is your feature request related to a problem?

If we want to make our xdr and dcd reading and writing libraries cython importable and public as discussed in #3734, the cython classes in the respective .pyx files need to have accompanying .pxd files that expose the implementation.

Describe the solution you'd like

The required pxd files should expose the cython datastructures.

Additional context

I will likely do this in a separate PR #3888 for the libdcd as its changes are targeted at 3.0, while for libmdaxdr this can be done in #3892.

@hmacdope hmacdope added the CZI-performance performance track of CZIEOSS4 grant label Nov 6, 2022
@hmacdope hmacdope self-assigned this Nov 6, 2022
@hmacdope hmacdope moved this to In Progress in CZI Performance track Nov 6, 2022
@hmacdope
Copy link
Member Author

hmacdope commented Nov 7, 2022

EDIT: Change of plans I have "pxdified" libdcd in #3888

@hmacdope
Copy link
Member Author

with the merge of #3892 this is now addressed.

Repository owner moved this from In Progress to Done in CZI Performance track Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CZI-performance performance track of CZIEOSS4 grant
Projects
Development

No branches or pull requests

1 participant