Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update performance plot #566

Open
andersfylling opened this issue Sep 18, 2023 · 1 comment
Open

Update performance plot #566

andersfylling opened this issue Sep 18, 2023 · 1 comment

Comments

@andersfylling
Copy link

andersfylling commented Sep 18, 2023 •
edited
Loading

Hello! I find these coroutine projects very interesting, but I'm having some issues replicating the performance. I noticed that the graph used on the readme file is around 7 years old. Is it perhaps time to update it? =)

An idea would be to update it on major python releases.
@andersfylling andersfylling changed the title update performance plot Update performance plot Sep 22, 2023
@FeldrinH
Copy link

FeldrinH commented May 3, 2024 •
edited
Loading

@andersfylling For reference, since the plot in the readme hasn't been updated (yet), could you post the performance numbers that you got?

odrling added a commit to Japan7/nanapi that referenced this issue Sep 23, 2024
@odrling
remove dependency on uvloop
ed69f38 
if needed we should be using hypercorn[uvloop] at this point. uvicorn is
not used afaik so not sure it should be a dev dependency.

(I’m actually not even sure if our current configuration uses uvloop at
all?)

uvloop seems to have some issues of its own (not present in asyncio) and
the performance claim might not be real at this point in time:
MagicStack/uvloop#566
@odrling odrling mentioned this issue Sep 23, 2024
Merged
odrling added a commit to Japan7/nanapi that referenced this issue Sep 24, 2024
@odrling
remove dependency on uvloop
ceba76f 
if needed we should be using hypercorn[uvloop] at this point. uvicorn is
not used afaik so not sure it should be a dev dependency.

(I’m actually not even sure if our current configuration uses uvloop at
all?)

uvloop seems to have some issues of its own (not present in asyncio) and
the performance claim might not be real at this point in time:
MagicStack/uvloop#566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FeldrinH @andersfylling