Change behaviour of getindex/getproperty for plotobjects #4212
SimonDanisch
started this conversation in
Ideas
Replies: 1 comment
-
Is this still planned or can this be closed? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
To break up #1085, I want to start changing the behaviour of getindex/getproperty, without getting into the huge refactor of also changing the planned internal implementation of the plot objects.
The plan is to, change
plot.attribute_name
to:p = plot!(..., color=:red); p.color
will returnRGBAf(...)
. This will help to get rid of lots of Observable indirection and double conversions.p.color = :red
will still work and convert immediatelyobserve(p, :color)
p[1]
anymore.. We may want to keepp.args[1]
for backward compatability, thoughp.kw_args
to make it possible to access the plot attributes the way the kw arguments allow. E.g., I want to convert colormaps + colorrange to a new object, that will sit atplot.color
(idea not yet final). So,p = plot!(..., color=x, colorrange=...); p.color
will not returnx
but instead some kind of color sampler object, which can be annoying. So the proposal would be to allowp.kw_args.color == x; p.kw_args.color = new_x
, which also opens up the possibility to allow for some magic keyword args.This all will help a lot with type stability and getting rid of lots of Observable indirections, which are slow to compile and run.
It aims to also make the API cleaner and easier to work with.
Beta Was this translation helpful? Give feedback.
All reactions