Ship Detector - recommend changing "Duty Cycle Data" to "Remove Extreme Low Outliers"

[kmerkens]

Hi Alba & co.,

The code included in the Ship Detector that is supposed to deal with Duty Cycled Data does not seem to do that (sh_passage_detector.m Lines 103-112). It does remove/NaN any extreme low outlier data points (which might happen if there is a data dropout), but based on what I've seen most duty cycled data does not have gaps in the actual data, just jumps in the time stamps. Additionally, this code only works correctly if one has applied a tf or calibration value that makes the pwr values positive (otherwise it NaNs almost all of the data).

I propose that this check box be "rebranded". One option might be that on the initial Settings gui window the check box could be renamed from "Duty Cycle Data" to something like "Remove Extreme Low Outliers (requires tf/calibration value)". Alternatively, gray-out the "Duty Cycle Data" option, so it's clear that is not functional, and add a new check box that allows a user to select the "Remove Extreme Low Outliers" function.

Either of these small changes would more accurately represent what this selection actually does, and it would prevent unsuspecting users from mistakenly thinking that the Remora should work well for duty cycled data.

(I'm still working on how to make the code functional for duty cycled data, and will get back to you if/when I find a way to work around that!)

-Karli

https://github.com/MarineBioAcousticsRC/Triton/blob/929192df3b660f53e25253ebc691035016e361c0/Remoras/Ship-Detector/detection/sh_passage_detector.m#L103C1-L112C4