Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Facets #2979

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Job Facets #2979

merged 2 commits into from
Nov 12, 2024

Conversation

phixMe
Copy link
Member

@phixMe phixMe commented Nov 12, 2024

image

One-line summary: Adding Job facets

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: phixMe <peter.hicks@pdtechsolutions.com>
@boring-cyborg boring-cyborg bot added the web label Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for peppy-sprite-186812 failed.

Name Link
🔨 Latest commit 485e1e2
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6733e5e32cc8970008849929

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (157d586) to head (485e1e2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2979   +/-   ##
=========================================
  Coverage     81.19%   81.19%           
  Complexity     1506     1506           
=========================================
  Files           268      268           
  Lines          7360     7360           
  Branches        325      325           
=========================================
  Hits           5976     5976           
  Misses         1226     1226           
  Partials        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phixMe phixMe merged commit 41d9d3d into main Nov 12, 2024
12 of 16 checks passed
@phixMe phixMe deleted the feature/job-facets branch November 12, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants