You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Originally _plot_and_save_spatial_plot was intended for 2D maps. With the introduction of the transects (which are also a 2D field, but arguably not a spatial plot) the role of _plot_and_save_spatial_plot was expanded. There are several other plots which required 2D plotting between two fields: Hovmoller diagrams, CFADs (#1010), 2D histograms (#1011), etc. It makes sense to reuse the capability we have. The questions then become
should we make the function more generic, rather than just "spatial"?
will the function become unwieldy with several if statements (some of which show only partial test coverage)?
should we rename the function/and any others for clarity for developers?
The text was updated successfully, but these errors were encountered:
Originally
_plot_and_save_spatial_plot
was intended for 2D maps. With the introduction of the transects (which are also a 2D field, but arguably not a spatial plot) the role of_plot_and_save_spatial_plot
was expanded. There are several other plots which required 2D plotting between two fields: Hovmoller diagrams, CFADs (#1010), 2D histograms (#1011), etc. It makes sense to reuse the capability we have. The questions then becomeThe text was updated successfully, but these errors were encountered: