Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should _plot_and_save_spatial_plot be made more generic, and as such renamed? #1014

Open
daflack opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels
question Further information is requested

Comments

@daflack
Copy link
Contributor

daflack commented Dec 19, 2024

Originally _plot_and_save_spatial_plot was intended for 2D maps. With the introduction of the transects (which are also a 2D field, but arguably not a spatial plot) the role of _plot_and_save_spatial_plot was expanded. There are several other plots which required 2D plotting between two fields: Hovmoller diagrams, CFADs (#1010), 2D histograms (#1011), etc. It makes sense to reuse the capability we have. The questions then become

  • should we make the function more generic, rather than just "spatial"?
  • will the function become unwieldy with several if statements (some of which show only partial test coverage)?
  • should we rename the function/and any others for clarity for developers?
@daflack daflack added the question Further information is requested label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants