Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds DKE functionality #1002

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Adds DKE functionality #1002

wants to merge 10 commits into from

Conversation

daflack
Copy link
Contributor

@daflack daflack commented Dec 16, 2024 •
edited
Loading

Adds Difference Kinetic Energy functionality to be able to look at ensemble spread.

Fixes #991

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@daflack daflack self-assigned this Dec 16, 2024
@daflack daflack marked this pull request as draft December 16, 2024 13:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Coverage

@daflack daflack added the enhancement New feature or request label Dec 16, 2024
@daflack
Copy link
Contributor Author

daflack commented Dec 16, 2024

I've realized that some fundamental functionality (i.e. stratify by ensemble member #132) is needed to allow me to go any further with this PR. Therefore, I am putting this PR on hold and switching to a new PR for #132.

@daflack
Copy link
Contributor Author

daflack commented Dec 16, 2024

Following on from previous comment, can now pick this up again given functionality of the generate_levels_constraint operator, so re-starting work on this operator.

@daflack daflack marked this pull request as ready for review December 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwarner8 jwarner8 Awaiting requested review from jwarner8

@jfrost-mo jfrost-mo Awaiting requested review from jfrost-mo

@Sylviabohnenstengel Sylviabohnenstengel Awaiting requested review from Sylviabohnenstengel

At least 1 approving review is required to merge this pull request.

Assignees

@daflack daflack

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial implementation of Difference Kinetic Energy
1 participant
@daflack