Show Webpack compilation warnings in CLI #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
Feb 15, 2024
| environment: defaulted(record(string(), unknown()), { | ||
| NODE_DEBUG: false, | ||
| NODE_ENV: 'production', | ||
| DEBUG: false, | ||
| }), | ||
| environment: defaulted(record(string(), unknown()), {}), |
There was a problem hiding this comment.
Previously, the defaults would be completely ignored if any value was used. I've changed it to merge the defaults with the custom values provided in the config.
Mrtenz
commented
Feb 15, 2024
| */ | ||
| new EnvironmentPlugin(config.environment), | ||
| new DefinePlugin(getEnvironmentVariables(config.environment)), |
There was a problem hiding this comment.
EnvironmentPlugin was causing compiler warnings. Switching to DefinePlugin seems to have resolved this issue.
Mrtenz
commented
Feb 15, 2024
Comment on lines
+99
to
+101
| const path = dirname(this.resourcePath); | ||
| for (const name of Object.keys(imports)) { | ||
| this.addDependency(name); | ||
| this.addDependency(resolve(path, name)); |
There was a problem hiding this comment.
Dependencies must use absolute paths. This solves a warning when using the WASM loader.
FrederikBolding
approved these changes
Feb 15, 2024
Mrtenz
force-pushed
the
mrtenz/show-compilation-warnings
branch
from
b7a200d
to
c6e6a3e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
=======================================
Coverage 96.54% 96.55%
=======================================
Files 331 331
Lines 7466 7482 +16
Branches 1148 1152 +4
=======================================
+ Hits 7208 7224 +16
Misses 258 258 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation warnings were previously ignored, potentially hiding important warnings from Webpack. This updates the Webpack config to show these warnings, and does some other changes to make warnings more readable.
Closes #2145.