Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game crashes when dropping an item in menu #703

Open
Galaxy7172 opened this issue Oct 20, 2024 · 4 comments · May be fixed by #704
Open

Game crashes when dropping an item in menu #703

Galaxy7172 opened this issue Oct 20, 2024 · 4 comments · May be fixed by #704
Labels
Application Crash Issue related to application crash, a crash report may be included. Bug Something that shouldn't happen. Controls Issue related to user controls. UI/Menus Issue related to (G)UI or menus/displays.

Comments

@Galaxy7172
Copy link

Galaxy7172 commented Oct 20, 2024 •
edited
Loading

Describe the bug
The game crashes when dropping any item with Q or Shift-Q

Steps to reproduce the error:

  1. Grab any item
  2. Drop item with Q or Shift-Q

Log
Unhandled error: General Application Crash
java.lang.ClassCastException: minicraft.screen.Menu cannot be cast to minicraft.screen.InventoryMenu
at minicraft.screen.PlayerInvDisplay.update(PlayerInvDisplay.java:361)
at minicraft.screen.InventoryMenu.tick(InventoryMenu.java:67)
at minicraft.screen.Display.tick(Display.java:102)
at minicraft.screen.PlayerInvDisplay.tick(PlayerInvDisplay.java:88)
at minicraft.core.Updater.tick(Updater.java:192)
at minicraft.core.Initializer.run(Initializer.java:95)
at minicraft.core.Game.main(Game.java:133)
@Galaxy7172 Galaxy7172 added the Bug Something that shouldn't happen. label Oct 20, 2024
@greenbean765
Copy link

I'd like to add that the bug doesn't affect creative mode, implying that for some reason dropping items is handled differently between gamemodes.

@BenCheung0422 BenCheung0422 added the UI/Menus Issue related to (G)UI or menus/displays. label Oct 21, 2024
@BenCheung0422 BenCheung0422 linked a pull request Oct 21, 2024 that will close this issue
Open
@BenCheung0422 BenCheung0422 added Application Crash Issue related to application crash, a crash report may be included. Controls Issue related to user controls. labels Oct 21, 2024
@BenCheung0422
Copy link
Member

Why was #461 mentioned?

@Galaxy7172
Copy link
Author

Apologies for the 461 being mentioned, I thought it would help with the issue of the bug described with as it would be mentioned with the crash report system.

@BenCheung0422
Copy link
Member

Actually that issue is a separate thing.

@BenCheung0422 BenCheung0422 changed the title Game crashes when dropping an item in 2.2.1-dev2(pre-release2) Game crashes when dropping an item Oct 26, 2024
@BenCheung0422 BenCheung0422 changed the title Game crashes when dropping an item Game crashes when dropping an item in menu Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Application Crash Issue related to application crash, a crash report may be included. Bug Something that shouldn't happen. Controls Issue related to user controls. UI/Menus Issue related to (G)UI or menus/displays.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unconstrained code for PlayerInvDisplay menu updating BenCheung0422/minicraft-plus-revived
3 participants
@greenbean765 @BenCheung0422 @Galaxy7172