Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] MRTKLifecycleManager logging should be optional #921

Open
Schroedingers-Cat opened this issue Sep 12, 2024 · 1 comment
Labels
Priority: Low The priority of the issue is low. Type: Feature Request A request for a new feature that can be included with the next minor version release.

Comments

@Schroedingers-Cat
Copy link

Describe the problem

Whenever we start our MRTK3 based project, we get the following log entries in our Unity console:

[MRTKLifecycleManager] Creating MixedReality.Toolkit.Input.MRTKHandsAggregatorSubsystem
UnityEngine.Debug:Log (object)
MixedReality.Toolkit.Subsystems.MRTKLifecycleManager:Awake () (at ./Library/PackageCache/org.mixedrealitytoolkit.core@e3175375067f/Subsystems/MRTKLifecycleManager.cs:71)

[MRTKLifecycleManager] Creating MixedReality.Toolkit.Input.OpenXRHandsSubsystem
UnityEngine.Debug:Log (object)
MixedReality.Toolkit.Subsystems.MRTKLifecycleManager:Awake () (at ./Library/PackageCache/org.mixedrealitytoolkit.core@e3175375067f/Subsystems/MRTKLifecycleManager.cs:71)

[MRTKLifecycleManager] Creating MixedReality.Toolkit.Input.SyntheticHandsSubsystem
UnityEngine.Debug:Log (object)
MixedReality.Toolkit.Subsystems.MRTKLifecycleManager:Awake () (at ./Library/PackageCache/org.mixedrealitytoolkit.core@e3175375067f/Subsystems/MRTKLifecycleManager.cs:71)

[MRTKLifecycleManager] Starting MixedReality.Toolkit.Input.MRTKHandsAggregatorSubsystem
UnityEngine.Debug:Log (object)
MixedReality.Toolkit.Subsystems.MRTKLifecycleManager:OnEnable () (at ./Library/PackageCache/org.mixedrealitytoolkit.core@e3175375067f/Subsystems/MRTKLifecycleManager.cs:122)

[MRTKLifecycleManager] Starting MixedReality.Toolkit.Input.OpenXRHandsSubsystem
UnityEngine.Debug:Log (object)
MixedReality.Toolkit.Subsystems.MRTKLifecycleManager:OnEnable () (at ./Library/PackageCache/org.mixedrealitytoolkit.core@e3175375067f/Subsystems/MRTKLifecycleManager.cs:122)

[MRTKLifecycleManager] Starting MixedReality.Toolkit.Input.SyntheticHandsSubsystem
UnityEngine.Debug:Log (object)
MixedReality.Toolkit.Subsystems.MRTKLifecycleManager:OnEnable () (at ./Library/PackageCache/org.mixedrealitytoolkit.core@e3175375067f/Subsystems/MRTKLifecycleManager.cs:122)

These messages are not interesting for anybody on our team or relevant to get work done on our project.

Describe the solution you'd like

A simple bool on the MRTK Lifecycle Manager component switching off debug logs would suffice since we don't need these logs to get any work done. Errors and warnings from the MRTK Lifecycle Manager should not be affected by this.

Describe alternatives you've considered

We could filter out all debug logs in the console but then we'd miss debug logs from our own systems (which can already be enabled and disabled per component instance).

We could also change the source code ourselves and alter the package's tarball file but we'd have to do that for every new MRTK release.

@Schroedingers-Cat Schroedingers-Cat added Needs: Triage Needs to be triaged. Type: Feature Request A request for a new feature that can be included with the next minor version release. labels Sep 12, 2024
@AMollis
Copy link
Contributor

AMollis commented Sep 25, 2024

Make sense. Would be a nice to have. We can look into making this configurable.

@AMollis AMollis added Priority: Low The priority of the issue is low. and removed Needs: Triage Needs to be triaged. labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low The priority of the issue is low. Type: Feature Request A request for a new feature that can be included with the next minor version release.
Projects
None yet
Development

No branches or pull requests

2 participants