Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken links to MotrpacRatTraining6moData objects #27

Closed
nicolerg opened this issue Sep 22, 2022 · 6 comments
Closed

broken links to MotrpacRatTraining6moData objects #27

nicolerg opened this issue Sep 22, 2022 · 6 comments

Comments

@nicolerg
Copy link
Collaborator

References to data objects in MotrpacRatTraining6moData within documentation for MotrpacRatTraining6mo are broken.

For example, see links here.

Something that should be https://motrpac.github.io/MotrpacRatTraining6moData/reference/TISSUE_ABBREV.html is https://rdrr.io/pkg/MotrpacRatTraining6moData/man/TISSUE_ABBREV.html (broken)

@nicolerg
Copy link
Collaborator Author

nicolerg commented Oct 3, 2022

@bcjaeger how did you get your documentation on rdrr.io? e.g. https://rdrr.io/github/bcjaeger/orsf2/man/aorsf-package.html

@bcjaeger
Copy link

bcjaeger commented Oct 3, 2022

Howdy! I'm not sure exactly how rdrr knows that aorsf is an R package but doesn't know MotrpacRatTraining6moData is one. It should incorporate all R packages on GitHub automatically.

I would try usethis::use_package_doc() to make a file for package-level documentation. This may be how rdrr identifies R packages on GitHub.

@bcjaeger
Copy link

bcjaeger commented Oct 3, 2022

My personal experience with links in R packages is that they are often unreliable. However, links to pages on your pkgdown website are much more reliable.

E.g., I think putting a link to https://motrpac.github.io/MotrpacRatTraining6moData/reference/ASSAY_ABBREV.html in your docs will be more reliable than rdrr or another source. Since roxygen lets you do markdown syntax, you can make the links look less crazy the normal way, e.g., see ASSAY_ABBREV documentation

@nicolerg
Copy link
Collaborator Author

nicolerg commented Oct 3, 2022

Thank you! I think I found the solution here, i.e. add the GitHub pages URL to both DESCRIPTION and _pkgdown.yml. Working on it...

@nicolerg
Copy link
Collaborator Author

nicolerg commented Oct 4, 2022

Unfortunately neither adding the pkgdown site URLs and rebuilding nor adding the file generated by usethis::use_package_doc() resolved this. I submitted r-lib/pkgdown#2203 asking about cross-package linking and rdrr-io/rdrr-issues#103 asking how/if these packages can be added to https://rdrr.io/.

@nicolerg
Copy link
Collaborator Author

Resolved! Possibly by updating pkgdown and downlit? But creating the pkgdown website with the GitHub Action resolved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants