Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results often don't cover subclasses of diseases #40

Open
sharatisrani opened this issue Aug 25, 2023 · 2 comments
Open

Results often don't cover subclasses of diseases #40

sharatisrani opened this issue Aug 25, 2023 · 2 comments
Labels
critical important to fix

Comments

@sharatisrani
Copy link
Collaborator

Whether we take Ehler's Danlos (with many subtypes like hypermobility, vascular, ....) or even the widespread T2D (with subtypes non-insulin dependent 1..4), results didn't cover those mondos. Suspect this is a common issue across many MVP1 queries.

See pk 7ff23820-38b8-4905-87fa-3dc3912cfd68 for T2D, for instance. Run on CI.

@sharatisrani sharatisrani added the critical important to fix label Aug 25, 2023
@sierra-moxon
Copy link
Member

@sharatisrani - I think I misunderstood your concern with this ticket in the meeting yesterday.

When I test whether or not we're returning results for subclasses of the disease I query for, I see that we do return results.
e.g. I can search for "Bone Disease" and get back results for "Osteoporosis" (note: we still have work to do here, we sometimes have technical issues returning very leafy nodes in a deep hierarchy, see: NCATSTranslator/Feedback#52).

But your ask here is that we investigate if there are additional data sources that we could ingest to fill in the gaps where we currently don't have data for those subclassed diseases?

@sierra-moxon
Copy link
Member

I can not seem to pull up results on CI for that PK. Would you be willing to run the query you did again and post the full URL in this ticket?

@sierra-moxon sierra-moxon removed their assignment Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical important to fix
Projects
None yet
Development

No branches or pull requests

2 participants