Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset 596: bad answer ID for thrombin, duplicate of 595? #86

Closed
colleenXu opened this issue Jun 28, 2024 · 3 comments
Closed

Asset 596: bad answer ID for thrombin, duplicate of 595? #86

colleenXu opened this issue Jun 28, 2024 · 3 comments

Comments

@colleenXu
Copy link

Similar to 503 #83...

This asset says the expected output name is UNIPROTKB:P00734, which is the gene F2 + its proteins (Dev NodeNorm).

However, the output ID CHEMBL.TARGET:CHEMBL204 is likely something no ARA/KP recognizes. NodeNorm doesn't resolve this ID..

If we changed the expected output IDs to NCBIGene:2147 (primary ID) / UniProtKB:P00734, it may end up as a duplicate of Asset 595 (which has its own issue #85).

Should this test be removed as a duplicate?

@colleenXu
Copy link
Author

See #62 (comment) for latest notes on asset 595

@maximusunc
Copy link
Collaborator

I'm not sure I see why this is a duplicate, but the ID should probably be updated. Putting UNIPROTKB:P00734 into Name Resolver gives PR:000051041 which seems to be a subclass of thrombin.

@maximusunc
Copy link
Collaborator

Duplicate of #83

@maximusunc maximusunc marked this as a duplicate of #83 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants