Restaurant_card #1311
Restaurant_card #1311
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1311 +/- ##
=======================================
Coverage 12% 12%
=======================================
Files 266 266
Lines 7194 7194
=======================================
Hits 802 802
Misses 6392 6392 |
| class _RestaurantCardState extends State<RestaurantCard> { | ||
| bool isFavorite = false; | ||
|
|
||
| void _toggleFavorite() { | ||
| setState(() { | ||
| isFavorite = !isFavorite; | ||
| }); | ||
| } | ||
|
|
||
| IconData? _getIconForMenuItemType(String type) { |
There was a problem hiding this comment.
Extend a StatelessWidget instead.
The isFavorite state should be outside this widget and passed as a simple boolean argument. Also add the possibility to pass void function to run on favorite icon click.
There was a problem hiding this comment.
Okok! I'll fix that 😊
| Color _getIconColorForMenuItemType(String type) { | ||
| return Theme.of(context).colorScheme.primary; | ||
| } |
There was a problem hiding this comment.
Looks a little redundant. I would remove that and put the theme property directly on line 116.
|
Change the color of the text to black; |
|
@clarapbsousa can you take a look into this? |
Closes #1274
Created new Restaurante card, with all the options
Review checklist
whatsnew/whatsnew-pt-PTchangelog.mdwith the changeEstablishments and meals
Favourite