Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional reservoir outputs needed for Lake Out files #466

Open
jdmattern opened this issue Oct 8, 2021 · 0 comments · May be fixed by #488
Open

Additional reservoir outputs needed for Lake Out files #466

jdmattern opened this issue Oct 8, 2021 · 0 comments · May be fixed by #488

Comments

@jdmattern
Copy link
Contributor

The current NWM 2.1 Lake Out files have additional fields for "reservoir_type" and "reservoir_assimilated_value". These values are also needed for NWM 3.0. These values do not affect anything in the model and are only for output purposes to assist the user in evaluating Hybrid and RFC type reservoirs. These values are dynamic and output from Hybrid and RFC type reservoirs at every timestep.

Examples of the areas that these need to be added:

https://github.com/NOAA-OWP/t-route/blob/master/src/python_routing_v02/troute/routing/fast_reach/mc_reach.pyx#L1315

https://github.com/NOAA-OWP/t-route/blob/master/src/python_framework_v02/troute/network/reservoirs/hybrid/hybrid.pyx#L137

https://github.com/NOAA-OWP/t-route/blob/master/src/python_framework_v02/troute/network/reservoirs/hybrid/hybrid_structs.c#L94

@jdmattern-noaa will make these additions.

@mehdire61 for potential further correspondence on this too.

@jdmattern jdmattern linked a pull request Oct 28, 2021 that will close this issue
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant