UI image names don't match images #1248
Labels
Comments
|
When the official app is updated it can jumble the image content. This is why we moved from using the apps official tokens and redwolf opted to create new tokens to ensure they wouldnt get jumbled again. This is the first time I've seen it happening to images, but I noticed the same problem. Personally I've opted to source my own images in the scenarios to avoid this. |
|
All Images with a non unique filename like Update: I crawled for problematic images using all available scenarios and this table: Click to expand!My results are: Click to expand!I found this using this code: Click to expand!namespace ImageSearch
{
class Program
{
static void Main(string[] args)
{
var path = System.IO.Path.GetDirectoryName(new System.Uri(System.Reflection.Assembly.GetExecutingAssembly().CodeBase).LocalPath);
var scenarioDir = Path.Combine(path, "scenarios");
var problemsFile = Path.Combine(path, "problems.txt");
var problems = File.ReadAllLines(problemsFile);
var iniFiles = Directory.GetFiles(scenarioDir,"*.ini", SearchOption.AllDirectories);
var problematicImages = new List<string>();
foreach(var iniFile in iniFiles)
{
var lines = File.ReadAllLines(iniFile);
int lineCount = 0;
foreach(var line in lines)
{
lineCount++;
foreach(var problem in problems)
{
if (line.Contains(problem))
{
var filename = Path.GetRelativePath(scenarioDir, iniFile);
Console.WriteLine(filename + " at line " + lineCount + " with image " + problem);
if (!problematicImages.Contains(problem))
{
problematicImages.Add(problem);
}
}
}
}
}
Console.WriteLine();
Console.WriteLine("Problematic images:");
foreach (var problematicImage in problematicImages)
{
Console.WriteLine(problematicImage);
}
}
}
}Click to expand!And here are the problematic images. Count hints how much they were used. I would suggest replacing all images with a generic one like this:
I created a pull request for it: The impact is quite big:
|
|
Nice work. Perhaps it would be best to remove the ability to use any of the FF images so no new dependencies on the remaining FF images are created by scenario authors in the future. |
|
This removes all images without a unique name, so some images can still be used. |
|
Ouch, it's frustrating that the images keep getting jumbled. |
|
A better but time consuming solution would be to readd support one by one. But this is the best quickfix besides adding the orifinal FFG images, we have for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of Problem or Question
I noticed that with the latest version of Valkyrie, the opening UI image for my existing published scenario from August of 2019 is no longer the one I selected when I built the module. Upon further investigation, I have found that for most of the images, after selecting an image for the UI "Image" field, the image title that appears doesn't seem to be the correct one for the image. I have all of the expansions including Path of the Serpent installed in my collection and imported.
This problem can be replicated by creating a New Scenario, adding a new UI component, clicking on the image field and then the "None" list item, and selecting, for example, the image of a train on a trestle. The image title that appears is "ImageOfficeWithBlood".
I tried running the MoM app, disabling PoTS in my collection, then restarting Valkyrie and re-importing my collection. That didn't fix the problem.
Valkyrie Version
2.4.06
The text was updated successfully, but these errors were encountered: