Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad lat/lon specifications causing editor hangups #432

Open
scott2b opened this issue Nov 26, 2019 · 2 comments
Open

bad lat/lon specifications causing editor hangups #432

scott2b opened this issue Nov 26, 2019 · 2 comments
Labels

Comments

@scott2b
Copy link
Member

scott2b commented Nov 26, 2019

Users who are interpreting the helper text to mean that their lat/lon values should be enclosed in angle brackets <>, are having editor hangups due to the inability to interpret the resulting bracketed values.

In general, we should probably clean out non-numeric characters when we parse lat/lon from the input here https://github.com/NUKnightLab/StoryMapJS/blob/master/templates/edit.html#L1621

@scott2b scott2b added the bug label Nov 26, 2019
@scott2b
Copy link
Member Author

scott2b commented Aug 25, 2020

An additional bug has surfaced which seems to indicate that the parser is not cleanly extracting lat and lon values in the case of extraneous symbols. In this case, it appeared that the user may have included a comma after the lat value, which was being propagated to the StoryMap data.

@scott2b
Copy link
Member Author

scott2b commented Aug 28, 2020

I am unable to reproduce this latter issue with respect to commas leaking into the data. The relevant parsing code is here:

function parseLatLon(s) {

I see no indication that a comma should be captured nor that the values for lat and lon should end up being stored as strings rather than decimal values. I do see that there is a token split that is not utilized which seems to probably be an artifact of an attempt at a different approach, but seems like a benign no-op effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant