-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: reduce_by_key
fails with zip_iterator to const pointers
#1527
Labels
bug
Something isn't working right.
Comments
A possible workaround here is to |
Are you building against current main or a specific branch? |
I just checked, the issue is still present in |
miscco
added a commit
to miscco/cccl
that referenced
this issue
Mar 11, 2024
It seems that explicitly passing in `thrust::device` was key here, otherwise the bug did not manifest Fixes [BUG]: `reduce_by_key` fails with zip_iterator to const pointers NVIDIA#1527
@upsj Thanks a lot for the bug report. I opened a PR with a fix and added your reproducer to out test suite |
miscco
added a commit
to miscco/cccl
that referenced
this issue
Mar 11, 2024
It seems that explicitly passing in `thrust::device` was key here, otherwise the bug did not manifest Fixes [BUG]: `reduce_by_key` fails with zip_iterator to const pointers NVIDIA#1527
That was quick, thank you very much! |
wmaxey
pushed a commit
that referenced
this issue
Mar 12, 2024
* Ensure that we can run `reduce_by_key` with const inputs It seems that explicitly passing in `thrust::device` was key here, otherwise the bug did not manifest Fixes [BUG]: `reduce_by_key` fails with zip_iterator to const pointers #1527 * Also address nvbug4550097 The explicit usage of `int` can give a conversion warning, so just use the right difference type * Update thrust/testing/zip_iterator_reduce_by_key.cu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this a duplicate?
Type of Bug
Compile-time Error
Component
Thrust
Describe the bug
The following code fails to compile with CUDA 12.4 (tracked by upstream issue ginkgo-project/ginkgo#1564)
Noteworthy: The issue goes away when the pointers are
int*
instead ofconst int*
How to Reproduce
nvcc file.cu
Expected behavior
The code compiles (as it did with CUDA <= 12.3)
Reproduction link
No response
Operating System
Ubuntu 22.04
nvidia-smi output
No response
NVCC version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2024 NVIDIA Corporation
Built on Tue_Feb_27_16:19:38_PST_2024
Cuda compilation tools, release 12.4, V12.4.99
Build cuda_12.4.r12.4/compiler.33961263_0
The text was updated successfully, but these errors were encountered: