Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUDIT] [SPARK-50229] change allattributes from lazy val to def #11861

Open
amahussein opened this issue Dec 11, 2024 · 0 comments
Open

[AUDIT] [SPARK-50229] change allattributes from lazy val to def #11861

amahussein opened this issue Dec 11, 2024 · 0 comments
Labels
audit General label for audit related tasks bug Something isn't working Spark 4.0+ Spark 4.0+ issues

Comments

@amahussein
Copy link
Collaborator

amahussein commented Dec 11, 2024

Describe the bug

[SPARK-50229] Reduce memory usage on driver for wide schemas by reducing the lifetime of AttributeReference objects created during logical planning apache/spark@4771638b3a6

In the above Spark commit, the allAttributes in QueryPlan to be a def instead of a lazy val. This affects the implementation of the expressions on the Plugin side.
For example

override lazy val allAttributes: AttributeSeq =
overrides the method as as a lazy val.

We need to fix that definition to match Spark4.0

@amahussein amahussein added ? - Needs Triage Need team to review and classify audit General label for audit related tasks bug Something isn't working Spark 4.0+ Spark 4.0+ issues labels Dec 11, 2024
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit General label for audit related tasks bug Something isn't working Spark 4.0+ Spark 4.0+ issues
Projects
None yet
Development

No branches or pull requests

2 participants