Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error checking for NPE #390

Open
aaronchantrill opened this issue Oct 5, 2023 · 0 comments
Open

Better error checking for NPE #390

aaronchantrill opened this issue Oct 5, 2023 · 0 comments
Labels
Good First Issue! Hacktoberfest Small or non-core issues that could be worked on by Hacktoberfest participants Priority: Medium Status: Available

Comments

@aaronchantrill
Copy link
Contributor

aaronchantrill commented Oct 5, 2023

Description

If anything fails while installing requirements from python_requirements.txt while installing a plugin, the NPE install succeeds but the plugin will be missing dependencies. We need to check the return code from npe.py line 276 where it runs the pip3 install command.

Expected Behavior

The installer should either quit with an error message letting the user know that the install failed or keep trying until the install succeeds.

Actual Behavior

The install continues. Eventually the error messages from pip scroll off the top of the screen. The last message says that the plugin has been installed. It is surprising when the plugin is not available the next time the user runs Naomi.

Possible Fix

if(run_command(cmd).returncode != 0):
    self._logger.error(f"Error installing {row['Name']}")
    exit()

Steps to Reproduce

  1. install Mimic3tts plugin from npe with a funky internet connection.
@aaronchantrill aaronchantrill added Status: Available Priority: Medium Good First Issue! Hacktoberfest Small or non-core issues that could be worked on by Hacktoberfest participants labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue! Hacktoberfest Small or non-core issues that could be worked on by Hacktoberfest participants Priority: Medium Status: Available
Projects
None yet
Development

No branches or pull requests

1 participant