Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle huge results #1

Open
Nemo64 opened this issue Mar 15, 2020 · 0 comments
Open

Gracefully handle huge results #1

Nemo64 opened this issue Mar 15, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@Nemo64
Copy link
Owner

Nemo64 commented Mar 15, 2020

The ExecuteStatement documentation warns about huge results.

The response size limit is 1 MB or 1,000 records. If the call returns more than 1 MB of response data or over 1,000 records, the call is terminated.

I tested queries with over 10,000 results and it worked fine but I wouldn't rely on it.

To prepare for the day they actually limit the result, queries should automatically get a LIMIT applied and be paged while iterating the result. The limit should be configurable (including unlimited) but default to 1,000 so the implementation follows the specification.

It may be possible to execute the request for the next page async but I have the experience that guzzle only actually starts the request when accessing it so there needs to be some investigation.

@Nemo64 Nemo64 added the enhancement New feature or request label Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant