Add App2E HTJ2K constraints validation #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() to avoid breaking change
Replaced dead links and updated language
danielhdz13-netflix
approved these changes
Aug 15, 2024
palemieux
requested changes
Aug 20, 2024
| "APP2.HT: Parameter B has exceeded its limits"); | ||
| isValid = false; | ||
| isValid = true; |
There was a problem hiding this comment.
Remove since isValid is true by default and you would not want to overwrite a false value.
| logger.addError( | ||
| IMFErrorLogger.IMFErrors.ErrorCodes.APPLICATION_COMPOSITION_ERROR, | ||
| IMFErrorLogger.IMFErrors.ErrorLevels.FATAL, | ||
| "APP2.HT: Parameter B has exceeded its limit to an extend that decoder issues are to be expected"); |
There was a problem hiding this comment.
"APP2.HT: Parameter B has exceeded its limit to an extent that decoder issues are to be expected");
| * TODO: This should be revisited as more implementations become available. | ||
| */ | ||
|
|
||
| if (codestreamB > 24) { |
There was a problem hiding this comment.
I would be inclined to use the max value allowed in Annex I, i.e., 21.
This was referenced Aug 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Branched off of PR #368 to work around GitHub permission issues.)
Closes #370
Validate the CPL essence descriptors against the APP2.HT.REV and APP2.HT.IRV constraint sets specified in ST 2067-21, Annex I.