[Feature/449] 이미지 3장 올리는 API 구현 #457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injoon2019
commented
Sep 25, 2024
| @@ -68,6 +68,15 @@ class UserProfileService( | |||
| fun uploadImageUrl(user: User, imageUrl: String, blurredImageUrl: String) { | |||
| profileRepository.findByUserId(user.id)?.let { | |||
| it.imageUrl = imageUrl | |||
| it.imageUrls = listOf(imageUrl) | |||
There was a problem hiding this comment.
이 pr이 배포나가게 되면 네이티브 배포 나가기 전에 image_urls 컬럼에도 채우게됩니다
There was a problem hiding this comment.
그럼 기존 유저들은 일단 imageUrls는 빈 배열로 되어있는거죠?
There was a problem hiding this comment.
맞아요! 이것도 이 pr 배포나가서 신규 유저들이 이미지 올리면 imageUrls에 쌓이게 된다면, 기존 유저들은 쿼리로 ["기존 imageUrl"] 이렇게 넣어줄 예정이에요
miseongk
approved these changes
Sep 26, 2024
| val originalImageUrls = files.zip(paths) | ||
| .map { (file, path) -> fileService.upload(file, path) } | ||
| .map { it.toString() } | ||
| val blurredImageUrl = imageUploader.uploadWithBlur(files[0], paths[0]); |
| @@ -30,6 +30,9 @@ class UserProfile( | |||
|
|
|||
| var imageUrl: String? = null, | |||
|
|
|||
| @Convert(converter = QuestionAndAnswerConverter::class) | |||
| @@ -68,6 +68,15 @@ class UserProfileService( | |||
| fun uploadImageUrl(user: User, imageUrl: String, blurredImageUrl: String) { | |||
| profileRepository.findByUserId(user.id)?.let { | |||
| it.imageUrl = imageUrl | |||
| it.imageUrls = listOf(imageUrl) | |||
There was a problem hiding this comment.
그럼 기존 유저들은 일단 imageUrls는 빈 배열로 되어있는거죠?
| fun upsertIntroductionAndImages( | ||
| @AuthUserId userId: Long, | ||
| @RequestPart("files") files: List<MultipartFile>, | ||
| @RequestPart("introduction") registerIntroductionRequest: RegisterIntroductionRequest, |
There was a problem hiding this comment.
사진이랑 ResponseBody랑 같이 보내려면 body도 RequestPart로 보내야하는건가요?!
miseongk
reviewed
Sep 26, 2024
| private val profileFacadeV2: UserProfileFacadeV2, | ||
| ) { | ||
|
|
||
| @ApiOperation("마이페이지 자기소개 & 사진들 등록/수정하기") |
There was a problem hiding this comment.
아! 그리고 저희 수정할 때는 자기소개랑 사진들 각각 수정할 수 있어야 할 것 같은데,
"사진들 수정하기 api"는 따로 있어야 하지 않을까요?
There was a problem hiding this comment.
요거 태환님이랑 얘기할때는 API 하나로 두고, 프론트에서 요청 보낼떄 사진 수정이더라도 자기소개까지 보내달라했어요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 이슈 번호
close: #449
✨ 작업 내용
🚀 전달 사항
https://www.notion.so/teamnexters/4046d5d312044bd89a7a12259b461616?pvs=4