Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port console.sol from Hardhat to EDR #641

Open
fvictorio opened this issue Sep 3, 2024 · 0 comments
Open

Port console.sol from Hardhat to EDR #641

fvictorio opened this issue Sep 3, 2024 · 0 comments
Milestone

Comments

@fvictorio
Copy link
Member

Some things are TBD, but my guess is that this means:

  • Doing the formatting on the EDR side. This in turn means that the API changes so that the host only receives an array of strings (or array of arrays of strings, if we want to be transparent about the parameters to the log calls; I'm not sure, but I suspect that it should just be a plain array of strings).
  • Generating the console.sol file
    • Unclear how Hardhat will in turn "re-export" this file, but seems solvable.

It's also unclear if we'll release this as part of Hardhat v2, because it's technically impossible to do without breaking changes given that the current definition of the behavior is "use Node.js's util.format".

@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Sep 3, 2024
@fvictorio fvictorio moved this from Unconfirmed to Todo in EDR Sep 3, 2024
@fvictorio fvictorio added this to the Hardhat v3 milestone Sep 3, 2024
@Xanewok Xanewok self-assigned this Sep 16, 2024
@Xanewok Xanewok moved this from Todo to In Progress in EDR Sep 16, 2024
@Xanewok Xanewok moved this from In Progress to Todo in EDR Sep 30, 2024
@Xanewok Xanewok removed their assignment Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants