Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pnpm + turbo #429

Open
FranciscoMoretti opened this issue Feb 3, 2023 · 3 comments
Open

Migrate to pnpm + turbo #429

FranciscoMoretti opened this issue Feb 3, 2023 · 3 comments

Comments

@FranciscoMoretti
Copy link

Description

Just wondering if there is any interest in moving from yarn + lerna to pnpm + turbo.

I've migrated this for myself on a local build and I'm experiencing a better developer experience.
The benefits I've got from it are:

  • Faster installs and dev runs
  • Better documentation (pnpm + turbo)
  • Fewer commands. E.g. This command starts dev for the minimal example and the packages that it depends upon: pnpm dev --filter notion-x-example-minimal...

My main motivation: As someone who started learning web development recently, migrating to pnpm + turbo was easier than learning yarn + lerna.

I can open a PR with the basic configuration if there is some interest in the topic. Feel free to close the issue if not.

@FranciscoMoretti FranciscoMoretti changed the title Move to pnpm + turbo Migrate to pnpm + turbo Feb 3, 2023
@mustaqimarifin
Copy link

had the same idea messing with next 13 and a lot of things werent playing too nice. Made small changes to the lazy image wrapper which I thought wouldnt be too bad but I kept having trouble building the project. Anyways, tried out the same combo and its working quite nicely react-notion-x-turbo

@transitive-bullshit
Copy link
Member

I'm open to this; will make for a tough PR, though.

@FranciscoMoretti
Copy link
Author

PR Created #461. You were right, it's a large one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants