Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change getCharacterizationResults to fetch by generationID #267

Open
jhardin29 opened this issue Nov 20, 2023 · 1 comment
Open

change getCharacterizationResults to fetch by generationID #267

jhardin29 opened this issue Nov 20, 2023 · 1 comment

Comments

@jhardin29
Copy link

Currently getCharacterizationResults exports using the characterization id, however if a single result has multiple runs resulting in many records, the pulling back generates many extra unneeded records.

It would be useful if you could just pass in a generation id of the desired results.

Tagging @chrisknoll because we chatted about this feature enhancement

@jhardin29 jhardin29 changed the title change getCharacterizationResults to accept to fetch by generationID change getCharacterizationResults to fetch by generationID Nov 20, 2023
@chrisknoll
Copy link
Collaborator

Right: it's not clear if the getCharacterizationResults is actually fetching the results for all generations at one time (which could be huge amounts of data if there were many generations, or if this was done across databases). The way the API works in Atlas is: you get a list of generation results, and the user selects a single result to fetch.

@gowthamrao what was the design intention of this ROhdsiWebAPI call?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants