-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAS-1290 Add clean get respondent by party_id endpoint to party service #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tested - everything returns properly and error handling works
/deploy pricem |
Deploying to dev cluster with following parameters:
|
As intended, SQLAlchemy query is nice and clean 👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding in the openapi spec that the existing overloaded method is deprecated?
What and why?
This Pr adds a new endpoint to get respondents by party_id. This card is part of bigger piece to removed the business associations currently returning from the respondents by id endpoint
How to test?
Deploy this PR and run the acceptance tests (or add a respondent) make sure when you call the endpoint you get the right response. Don't forget to include basic auth details
Jira