Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAS-1290 Add clean get respondent by party_id endpoint to party service #437

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

LJBabbage
Copy link
Contributor

@LJBabbage LJBabbage commented Oct 3, 2024

What and why?

This Pr adds a new endpoint to get respondents by party_id. This card is part of bigger piece to removed the business associations currently returning from the respondents by id endpoint

How to test?

Deploy this PR and run the acceptance tests (or add a respondent) make sure when you call the endpoint you get the right response. Don't forget to include basic auth details
Screenshot 2024-10-03 at 11 37 19

Jira

Copy link
Contributor

@arroyoAle arroyoAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested - everything returns properly and error handling works

@pricem14pc pricem14pc self-requested a review October 7, 2024 07:21
@pricem14pc
Copy link
Contributor

/deploy pricem

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: pricem

  • tag: pr-437

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

@pricem14pc
Copy link
Contributor

pricem14pc commented Oct 7, 2024

As intended, SQLAlchemy query is nice and clean 👍

SELECT 
partysvc.respondent.id AS partysvc_respondent_id,
 ...
 ...
partysvc.respondent.password_reset_counter AS partysvc_respondent_password_reset_counter
FROM partysvc.respondent
WHERE partysvc.respondent.party_uuid = 'b90478a4-0eb6-4f8c-865a-d5f2df7d09ff'::UUID
LIMIT 1

Copy link
Contributor

@pricem14pc pricem14pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding in the openapi spec that the existing overloaded method is deprecated?

@LJBabbage LJBabbage merged commit 30d6003 into main Oct 11, 2024
1 check passed
@LJBabbage LJBabbage deleted the add-get-respondent-by-party-id branch October 11, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants