Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables to control cors configuration in docker images #59

Open
eladav opened this issue Jul 11, 2019 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eladav
Copy link
Contributor

eladav commented Jul 11, 2019

The image uses the cors package from npm. The package is really configurable, check out
cors on npm. We need to think which configurations make sense and what is the best way to allow people to control them. If #58 is done before this it might affect the solution to this issue.

@eladav eladav added enhancement New feature or request good first issue Good for newcomers labels Jul 11, 2019
@Yshayy
Copy link

Yshayy commented Aug 14, 2019

Is there any reason to add more than "allowed origins"? I'd assume that browser apps should only fetch packages/components. Maybe even the default should be "*", since it's very similar to how browser fetch scripts/components from works from different domains.

@eladav
Copy link
Contributor Author

eladav commented Aug 14, 2019

Using * as the default definitely makes sense. I guess that allowed origins are the only thing that makes sense to configure. I’d say that most users indeed will go with a catch-all configuration. Bottom line: I think you’re right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants