Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local File Inclusion (LFI) Vulnerability #303

Closed
ap00rv opened this issue Feb 13, 2018 · 3 comments
Closed

Local File Inclusion (LFI) Vulnerability #303

ap00rv opened this issue Feb 13, 2018 · 3 comments

Comments

@ap00rv
Copy link

ap00rv commented Feb 13, 2018

image

The vulnerability can be exploited at this URL :

http://localhost:3000/download?name=public%2Fdocs%2FHealth_n_Stuff.pdf&type=File

If the 'name' parameter's value is changed to "/etc/passwd" , the file is donwloaded.

This issue was flagged by Brakeman scanner. The vulnerable code is present at line 11 of
railsgoat/app/controllers/benefit_forms_controller.rb

@cktricky
Copy link
Contributor

We do have this documented here but as noted in Issue #169... its categorized or co-mingled with another vuln in a weird way (demonstrating LFI/Traversal via metaprogramming). Although its kind of a duplicate issue, do appreciate you sending this in 👍

@ap00rv
Copy link
Author

ap00rv commented Feb 13, 2018

my apologies for not going through all of the documentation. Thank you for pointing it out . :)

@ap00rv ap00rv changed the title Undocumented Local File Inclusion (LFI) Vulnerability Local File Inclusion (LFI) Vulnerability Feb 13, 2018
@cktricky
Copy link
Contributor

Oh no, its not your fault, we didn't have it listed in Rails 5 (what master is at) and also, the issue is 3 years old so I should have fixed this by now. If anything, you reminded us (and me, specifically) that its important this is fixed. So... thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants