Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot-conversation-sso-quickstart csharp version has build errors #1326

Open
appieschot opened this issue Jul 10, 2024 · 2 comments
Open

bot-conversation-sso-quickstart csharp version has build errors #1326

appieschot opened this issue Jul 10, 2024 · 2 comments
Assignees

Comments

@appieschot
Copy link

appieschot commented Jul 10, 2024

When pulling in the csharp version of the bot-conversation-sso-quickstart available at: https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-conversation-sso-quickstart/csharp_dotnetcore/BotConversationSsoQuickstart

The F5 experience does not work due to a missing file (or wrong filepath depending on your take).

The build experience uses the file BotConversationSsoQuickstart\teamsapp.local.yml to run. That file contains teamsApp/validateManifest that refers to the following:

  - uses: teamsApp/validateManifest
    with:
      # Path to manifest template
      manifestPath: ./AppManifest/manifest.json

That file path does not exist, it most likely must point to ../TeamsApp/appPackage/manifest.json

The same is for all following steps:

  • zipAppPackage
  • validateAppPackage
  • update

Happy to create a pull request with changes if we agree on that approach.

@appieschot
Copy link
Author

In addition, the manifest.json in the /TeamsApp is working properly, I assume you could also safely remove the infra and teamsapp.yml files from the BotConversationSsoQuickstart project.

@Meghana-MSFT
Copy link
Collaborator

Meghana-MSFT commented Jul 10, 2024

@appieschot - Thank you for reporting this, we have informed this to the sample team. PR will be raised to make necessary changes.

Update: PR #1327 has been raised and merged for above issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants