Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change authentication logic to be per-job #169

Open
vvmnnnkv opened this issue Aug 2, 2020 · 1 comment
Open

Change authentication logic to be per-job #169

vvmnnnkv opened this issue Aug 2, 2020 · 1 comment
Assignees
@mjjimenez
Labels
Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase
Milestone
0.3.0

Comments

@vvmnnnkv
Copy link
Member

vvmnnnkv commented Aug 2, 2020

What?

Currently we authenticate once with model/version supplied in newJob, get worker_id from PyGrid and use it for all jobs.
Instead, we should authenticate for every newJob and store worker_id for given job only.

Why?

Each FL model has own auth settings, hence each job will have individual worker_id that works with corresponding model only.

Breakdown

  • Move authentication into newJob
  • Save worker_id on Job

Additional Context

See https://github.com/OpenMined/PyGrid/issues/628
@vvmnnnkv vvmnnnkv added the Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase label Aug 2, 2020
@vvmnnnkv vvmnnnkv added this to the 0.3.0 milestone Aug 2, 2020
@vvmnnnkv
Copy link
Member Author

vvmnnnkv commented Sep 9, 2020

Let's also rename worker_id to job_id!

@vvmnnnkv vvmnnnkv assigned vvmnnnkv and mjjimenez and unassigned vvmnnnkv Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjjimenez mjjimenez

Labels
Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
2 participants
@mjjimenez @vvmnnnkv