Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip linting of submodules #29

Open
Amxx opened this issue Nov 29, 2024 · 0 comments
Open

Skip linting of submodules #29

Amxx opened this issue Nov 29, 2024 · 0 comments

Comments

@Amxx
Copy link
Collaborator

Amxx commented Nov 29, 2024

Right now, the linter is configures as:

"lint": "npm run lint:js && npm run lint:sol",
"lint:fix": "npm run lint:js:fix && npm run lint:sol:fix",
"lint:js": "prettier --log-level warn --ignore-path .gitignore '**/*.{js,ts}' --check",
"lint:js:fix": "prettier --log-level warn --ignore-path .gitignore '**/*.{js,ts}' --write",
"lint:sol": "prettier --log-level warn --ignore-path .gitignore '{contracts,test}/**/*.sol' --check",
"lint:sol:fix": "prettier --log-level warn --ignore-path .gitignore '{contracts,test}/**/*.sol' --write",

While the solidity parts only run on contracts and test, the javascript/typescript part runs on all subfolders. This includes lib/* that contains the @openzeppelin/contracts submodules. These module include some javascript and typescript (tests, scripts, ...) thatare linted using a potentially different version/config of prettier.

This forces us to use the same prettier version/config as the main repos, which means we have to synchronise the updates.

We should configure linting in this repo so that lib/* is NOT linted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant