Migrating from OC1.4 -> OC.18 - Custom Modular Tenant Events failing

[weirdyang]

I am running into this issue while migrating 1.4 to 1.8.

I have a custom Modular tenant event which enables features based on a list in the appsettings.

    internal class EnableDefaultModulesStartupTask : ModularTenantEvents
    {
        private readonly IShellFeaturesManager _shellFeaturesManager;

        private readonly IShellConfiguration _shellConfiguration;

        const string ModuleSectionName = "DefaultModules";
        public EnableDefaultModulesStartupTask(
            IShellFeaturesManager shellFeaturesManager,
            IShellConfiguration shellConfiguration)
        {
            _shellFeaturesManager = shellFeaturesManager;
            _shellConfiguration = shellConfiguration;
        }
        public override async Task  ActivatingAsync()
        {

            // return 
            await EnableFeaturesAsync();

        }
        public async Task EnableFeaturesAsync() {
            if (_shellConfiguration
                .GetSection(ModuleSectionName)
                .Exists())
            {
                List<string> features = new();
                _shellConfiguration
                    .GetSection(ModuleSectionName)
                    .Bind(features);

                if (features.Any())
                {
                    IEnumerable<IFeatureInfo> availableFeatures = await _shellFeaturesManager
                        .GetAvailableFeaturesAsync();

                    IEnumerable<IFeatureInfo> featuresToEnable = availableFeatures
                        .Where(x =>
                        features.Any(feat =>
                        string.Equals(
                            x.Id,
                            feat,
                            StringComparison.InvariantCultureIgnoreCase)
                        )).ToList();

                    await _shellFeaturesManager.UpdateFeaturesAsync(
                        new List<IFeatureInfo>(),
                        featuresToEnable,
                        true);
                }
            }
        }
    }

It runs with no issue in 1.4, however, when I run it in 1.8 it throws this error:

Microsoft.Data.Sqlite.SqliteException.ThrowExceptionForRC(int rc, sqlite3 db)
Microsoft.Data.Sqlite.SqliteDataReader.NextResult()
Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior behavior)
Microsoft.Data.Sqlite.SqliteCommand.ExecuteReaderAsync(CommandBehavior behavior, CancellationToken cancellationToken)
Microsoft.Data.Sqlite.SqliteCommand.ExecuteDbDataReaderAsync(CommandBehavior behavior, CancellationToken cancellationToken)
YesSql.Commands.BatchCommand.ExecuteAsync(DbConnection connection, DbTransaction transaction, ISqlDialect dialect, ILogger logger)
YesSql.Session.FlushAsync()
YesSql.Session.FlushAsync()
YesSql.Session.SaveChangesAsync()
YesSql.Session.SaveChangesAsync()
OrchardCore.Data.Documents.DocumentStore.CommitAsync()
OrchardCore.Environment.Shell.Scope.ShellScope.BeforeDisposeAsync()
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Environment.Shell.Scope.ShellScope.UsingAsync(Func<ShellScope, Task> execute, bool activateShell)
OrchardCore.Recipes.Services.RecipeExecutor.ExecuteStepAsync(RecipeExecutionContext recipeStep)
OrchardCore.Recipes.Services.RecipeExecutor.ExecuteAsync(string executionId, RecipeDescriptor recipeDescriptor, IDictionary<string, object> environment, CancellationToken cancellationToken)
OrchardCore.Recipes.Services.RecipeExecutor.ExecuteAsync(string executionId, RecipeDescriptor recipeDescriptor, IDictionary<string, object> environment, CancellationToken cancellationToken)
OrchardCore.Recipes.Services.RecipeExecutor.ExecuteAsync(string executionId, RecipeDescriptor recipeDescriptor, IDictionary<string, object> environment, CancellationToken cancellationToken)
OrchardCore.Recipes.Services.RecipeExecutor.ExecuteAsync(string executionId, RecipeDescriptor recipeDescriptor, IDictionary<string, object> environment, CancellationToken cancellationToken)
OrchardCore.Setup.Services.SetupService.SetupInternalAsync(SetupContext context)
OrchardCore.Setup.Services.SetupService.SetupInternalAsync(SetupContext context)
OrchardCore.Setup.Services.SetupService.SetupAsync(SetupContext context)
OrchardCore.Setup.Services.SetupService.SetupAsync(SetupContext context)
OrchardCore.Setup.Controllers.SetupController.IndexPOST(SetupViewModel model)
lambda_method80(Closure , object )

I've verified it is not my recipe that is causing the issue because if I comment out this task, it doesn't throw the error.

What could it be? Am I activating modules wrongly?
I've attached my recipe below.
basic.recipe.json

[weirdyang]

hmm, is the solution to run the task after the recipe is executed? is there an event I can hook into? and why does this work in 1.4 but not 1.8.3?

[Piedone]

That can indeed be a solution. You can do that with a deferred task. See e.g. https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore/OrchardCore.Queries.Core/QueriesDocumentMigrationHelper.cs for an example.

[weirdyang]

Thanks that is so much better than a background task